Issue 607743005: Revert of PDF: Add some CHECKS to help debug a crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 607743005: Revert of PDF: Add some CHECKS to help debug a crash. (Closed)

Created:
6 years, 2 months ago by Lei Zhang

Modified:
6 years, 2 months ago

Reviewers:
gene

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Revert of PDF: Add some CHECKS to help debug a crash. (patchset #2 id:20001 of https://codereview.chromium.org/457873003/) Reason for revert: No longer needed. Original issue's description: > PDF: Add some CHECKS to help debug a crash. > > BUG=402035 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289822 TBR=gene@chromium.org NOTREECHECKS=true NOTRY=true BUG=402035 Committed: https://crrev.com/1bf565449d44e20e88d4b13d1006bf4ff1fa3b38 Cr-Commit-Position: refs/heads/master@{#297067}

Created: 6 years, 2 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	pdf/pdfium/pdfium_engine.cc	View		3 chunks	+0 lines, -6 lines	0 comments	Download

Total messages: 5 (0 generated)

Lei Zhang

Created Revert of PDF: Add some CHECKS to help debug a crash.

6 years, 2 months ago (2014-09-26 23:23:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607743005/1

6 years, 2 months ago (2014-09-26 23:25:23 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as 59dab843ecf4de822c4e14ef7ff0f770cea2fcd4

6 years, 2 months ago (2014-09-26 23:26:08 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-09-26 23:26:47 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1bf565449d44e20e88d4b13d1006bf4ff1fa3b38
Cr-Commit-Position: refs/heads/master@{#297067}