chrome/browser/ui/cocoa/tabs/tab_strip_controller.h - Issue 607723002: mac: Refactor tab strip layout logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_controller.h

Issue 607723002: mac: Refactor tab strip layout logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tabstrip_relayout_bug_base

Patch Set: Comments from rsesek. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/browser_window_layout.mm ('K') | « chrome/browser/ui/cocoa/browser_window_layout_unittest.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tabs/tab_strip_controller.h

diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.h b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.h

index fa1d28e830d097b34ccae90784bf75fcbe7c66b1..859e5971dab8300251ab33fd09e672232d804eb0 100644

--- a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.h

+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.h

@@ -140,9 +140,9 @@ class WebContents;

// Helper for performing tab selection as a result of dragging over a tab.

scoped_ptr<HoverTabSelector> hoverTabSelector_;

- // A container view for the window controls, which must be manually added in

- // fullscreen in 10.10+.

- base::scoped_nsobject<NSView> fullscreenWindowControls_;

+ // A container view for custom traffic light buttons, which must be manually

+ // added in fullscreen in 10.10+.

+ base::scoped_nsobject<NSView> customWindowControls_;

}

@property(nonatomic) CGFloat leftIndentForControls;

@@ -252,11 +252,11 @@ class WebContents;

// Returns the currently active TabContentsController.

- (TabContentsController*)activeTabContentsController;

-// Adds traffic lights to the tab strip. Idempotent.

-- (void)addWindowControls;

+// Adds custom traffic light buttons to the tab strip. Idempotent.

+- (void)addCustomWindowControls;

-// Removes traffic lights from the tab strip. Idempotent.

-- (void)removeWindowControls;

+// Removes custom traffic light buttons from the tab strip. Idempotent.

+- (void)removeCustomWindowControls;

@end