Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4045)

Unified Diff: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm

Issue 607723002: mac: Refactor tab strip layout logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tabstrip_relayout_bug_base
Patch Set: Fix unit test. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/tabs/tab_strip_controller.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
diff --git a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
index 2cf76db5addf1ae03e79d74034a44b45a7bd53ed..41a5a177b113ed9ba130122f438582f5b9c05433 100644
--- a/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
+++ b/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
@@ -2202,13 +2202,13 @@ NSImage* Overlay(NSImage* ground, NSImage* overlay, CGFloat alpha) {
return [tabContentsArray_ objectAtIndex:index];
}
-- (void)addWindowControls {
- if (!fullscreenWindowControls_) {
+- (void)addCustomWindowControls {
+ if (!customWindowControls_) {
// Make the container view.
CGFloat height = NSHeight([tabStripView_ frame]);
NSRect frame = NSMakeRect(0, 0, [self leftIndentForControls], height);
- fullscreenWindowControls_.reset([[NSView alloc] initWithFrame:frame]);
- [fullscreenWindowControls_
+ customWindowControls_.reset([[NSView alloc] initWithFrame:frame]);
+ [customWindowControls_
setAutoresizingMask:NSViewMaxXMargin | NSViewHeightSizable];
// Add the traffic light buttons. The horizontal layout was determined by
@@ -2224,31 +2224,31 @@ NSImage* Overlay(NSImage* ground, NSImage* overlay, CGFloat alpha) {
// Vertically center the buttons in the tab strip.
CGFloat buttonY = floor((height - NSHeight([closeButton bounds])) / 2);
[closeButton setFrameOrigin:NSMakePoint(closeButtonX, buttonY)];
- [fullscreenWindowControls_ addSubview:closeButton];
+ [customWindowControls_ addSubview:closeButton];
NSButton* miniaturizeButton =
[NSWindow standardWindowButton:NSWindowMiniaturizeButton
forStyleMask:styleMask];
[miniaturizeButton setFrameOrigin:NSMakePoint(miniButtonX, buttonY)];
[miniaturizeButton setEnabled:NO];
- [fullscreenWindowControls_ addSubview:miniaturizeButton];
+ [customWindowControls_ addSubview:miniaturizeButton];
NSButton* zoomButton =
[NSWindow standardWindowButton:NSWindowZoomButton
forStyleMask:styleMask];
- [fullscreenWindowControls_ addSubview:zoomButton];
+ [customWindowControls_ addSubview:zoomButton];
[zoomButton setFrameOrigin:NSMakePoint(zoomButtonX, buttonY)];
}
- if (![permanentSubviews_ containsObject:fullscreenWindowControls_]) {
- [self addSubviewToPermanentList:fullscreenWindowControls_];
+ if (![permanentSubviews_ containsObject:customWindowControls_]) {
+ [self addSubviewToPermanentList:customWindowControls_];
[self regenerateSubviewList];
}
}
-- (void)removeWindowControls {
- if (fullscreenWindowControls_)
- [permanentSubviews_ removeObject:fullscreenWindowControls_];
+- (void)removeCustomWindowControls {
+ if (customWindowControls_)
+ [permanentSubviews_ removeObject:customWindowControls_];
[self regenerateSubviewList];
}
« no previous file with comments | « chrome/browser/ui/cocoa/tabs/tab_strip_controller.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698