Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_controller_private.h

Issue 607723002: mac: Refactor tab strip layout logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tabstrip_relayout_bug_base
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_PRIVATE_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_PRIVATE_H_
6 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_PRIVATE_H_ 6 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_PRIVATE_H_
7 7
8 #import "chrome/browser/ui/cocoa/browser_window_controller.h" 8 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
9 #import "chrome/browser/ui/cocoa/browser_window_layout.h"
9 #import "chrome/browser/ui/cocoa/presentation_mode_controller.h" 10 #import "chrome/browser/ui/cocoa/presentation_mode_controller.h"
10 11
11 @class BrowserWindowLayout; 12 @class BrowserWindowLayout;
12 13
13 // Private methods for the |BrowserWindowController|. This category should 14 // Private methods for the |BrowserWindowController|. This category should
14 // contain the private methods used by different parts of the BWC; private 15 // contain the private methods used by different parts of the BWC; private
15 // methods used only by single parts should be declared in their own file. 16 // methods used only by single parts should be declared in their own file.
16 // TODO(viettrungluu): [crbug.com/35543] work on splitting out stuff from the 17 // TODO(viettrungluu): [crbug.com/35543] work on splitting out stuff from the
17 // BWC, and figuring out which methods belong here (need to unravel 18 // BWC, and figuring out which methods belong here (need to unravel
18 // "dependencies"). 19 // "dependencies").
(...skipping 17 matching lines...) Expand all
36 // content area, download shelf (if any). 37 // content area, download shelf (if any).
37 - (void)layoutSubviews; 38 - (void)layoutSubviews;
38 39
39 // Shows the informational "how to exit fullscreen" bubble. 40 // Shows the informational "how to exit fullscreen" bubble.
40 - (void)showFullscreenExitBubbleIfNecessary; 41 - (void)showFullscreenExitBubbleIfNecessary;
41 - (void)destroyFullscreenExitBubbleIfNecessary; 42 - (void)destroyFullscreenExitBubbleIfNecessary;
42 43
43 // Lays out the tab strip at the given maximum y-coordinate, with the given 44 // Lays out the tab strip at the given maximum y-coordinate, with the given
44 // width, possibly for fullscreen mode; returns the new maximum y (below the 45 // width, possibly for fullscreen mode; returns the new maximum y (below the
45 // tab strip). This is safe to call even when there is no tab strip. 46 // tab strip). This is safe to call even when there is no tab strip.
46 - (CGFloat)layoutTabStripAtMaxY:(CGFloat)maxY 47 - (void)applyTabStripLayout:(chrome::TabStripLayout)layout;
Robert Sesek 2014/09/26 16:55:54 const&
erikchen 2014/09/26 17:39:05 Done.
47 width:(CGFloat)width
48 fullscreen:(BOOL)fullscreen;
49 48
50 // Returns YES if the bookmark bar should be placed below the infobar, NO 49 // Returns YES if the bookmark bar should be placed below the infobar, NO
51 // otherwise. 50 // otherwise.
52 - (BOOL)placeBookmarkBarBelowInfoBar; 51 - (BOOL)placeBookmarkBarBelowInfoBar;
53 52
54 53
55 // Lays out the tab content area in the given frame. If the height changes, 54 // Lays out the tab content area in the given frame. If the height changes,
56 // sends a message to the renderer to resize. 55 // sends a message to the renderer to resize.
57 - (void)layoutTabContentArea:(NSRect)frame; 56 - (void)layoutTabContentArea:(NSRect)frame;
58 57
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 // to prevent redraws. 155 // to prevent redraws.
157 - (void)setContentViewSubviews:(NSArray*)subviews; 156 - (void)setContentViewSubviews:(NSArray*)subviews;
158 157
159 // A hack required to get NSThemeFrame sub layers to order correctly. See 158 // A hack required to get NSThemeFrame sub layers to order correctly. See
160 // implementation for more details. 159 // implementation for more details.
161 - (void)updateSubviewZOrderHack; 160 - (void)updateSubviewZOrderHack;
162 161
163 @end // @interface BrowserWindowController(Private) 162 @end // @interface BrowserWindowController(Private)
164 163
165 #endif // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_PRIVATE_H_ 164 #endif // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_PRIVATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698