Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 607693002: Update checklicenses.py to allow GPL v3 in ffmpeg code (Closed)

Created:
6 years, 2 months ago by jrummell
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update checklicenses.py to allow GPL v3 in ffmpeg code BUG= Committed: https://crrev.com/a2b9474fa2a7bccd0a353922967e9974146b2144 Cr-Commit-Position: refs/heads/master@{#296962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/checklicenses/checklicenses.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jrummell
PTAL. The offending ffmpeg file was removed so that the ffmpeg roll could get in ...
6 years, 2 months ago (2014-09-25 22:06:16 UTC) #2
Paweł Hajdan Jr.
LGTM
6 years, 2 months ago (2014-09-26 00:38:27 UTC) #3
DaleCurtis
lgtm
6 years, 2 months ago (2014-09-26 01:07:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607693002/1
6 years, 2 months ago (2014-09-26 16:20:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4e9357b134785a7fa4b2fa67deea6bc5e7ea3f15
6 years, 2 months ago (2014-09-26 16:59:03 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 16:59:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a2b9474fa2a7bccd0a353922967e9974146b2144
Cr-Commit-Position: refs/heads/master@{#296962}

Powered by Google App Engine
This is Rietveld 408576698