Simplify isEditingText

Simplify isEditingText

Since this method is only called from Text, we can
just ASSERT for isTextNode().

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183142

[rwlbuis, 2014-09-25 22:22:58]

rob.buis@samsung.com changed reviewers:
+ abarth@chromium.org

[rwlbuis, 2014-09-25 22:22:58]

PTAL

[rwlbuis, 2014-09-26 15:08:53]

rob.buis@samsung.com changed reviewers:
+ yosin@google.com

[rwlbuis, 2014-09-26 15:08:54]

Adding editing expert.

[rwlbuis, 2014-09-30 14:27:51]

ping?

[rwlbuis, 2014-10-01 10:34:02]

rob.buis@samsung.com changed reviewers:
+ yosin@chromium.org

[rwlbuis, 2014-10-01 10:34:02]

Using the right address this time :)

[yosin_UTC9, 2014-10-02 01:34:29]

yosin@chromium.org changed reviewers:
- yosin@google.com

[yosin_UTC9, 2014-10-02 01:34:30]

LGTM

We also want to use |ASSERT(!isText)| in hasName().

I see your reasoning. HasNameOrIsEditingTextFlag is combination of HasName, for
element, and IsEdigintText, for text, for saving bit fields.

[rwlbuis, 2014-10-02 01:59:22]

On 2014/10/02 01:34:30, Yosi_UTC9 wrote:
> LGTM
> 
> We also want to use |ASSERT(!isText)| in hasName().
> 
> I see your reasoning. HasNameOrIsEditingTextFlag is combination of HasName,
for
> element, and IsEdigintText, for text, for saving bit fields.

Good find regarding hasName! I will add it to the patch tomorrow, thanks for the
review.

[rwlbuis, 2014-10-02 14:14:06]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-10-02 14:14:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/607673002/20001

[commit-bot: I haz the power, 2014-10-02 15:58:33]

Committed patchset #2 (id:20001) as 183142