Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Side by Side Diff: src/lithium.cc

Issue 60763006: Replace hard-coded stack frame size literals with StandardFrameConstants::kFixedFrameSizeFromFp (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix merge error Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/frames.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 pointer_operands_[i]->PrintTo(stream); 230 pointer_operands_[i]->PrintTo(stream);
231 } 231 }
232 stream->Add("}"); 232 stream->Add("}");
233 } 233 }
234 234
235 235
236 int StackSlotOffset(int index) { 236 int StackSlotOffset(int index) {
237 if (index >= 0) { 237 if (index >= 0) {
238 // Local or spill slot. Skip the frame pointer, function, and 238 // Local or spill slot. Skip the frame pointer, function, and
239 // context in the fixed part of the frame. 239 // context in the fixed part of the frame.
240 return -(index + 3) * kPointerSize; 240 return -(index + 1) * kPointerSize -
241 StandardFrameConstants::kFixedFrameSizeFromFp;
241 } else { 242 } else {
242 // Incoming parameter. Skip the return address. 243 // Incoming parameter. Skip the return address.
243 return -(index + 1) * kPointerSize + kFPOnStackSize + kPCOnStackSize; 244 return -(index + 1) * kPointerSize + kFPOnStackSize + kPCOnStackSize;
244 } 245 }
245 } 246 }
246 247
247 248
248 LChunk::LChunk(CompilationInfo* info, HGraph* graph) 249 LChunk::LChunk(CompilationInfo* info, HGraph* graph)
249 : spill_slot_count_(0), 250 : spill_slot_count_(0),
250 info_(info), 251 info_(info),
(...skipping 220 matching lines...) Expand 10 before | Expand all | Expand 10 after
471 472
472 473
473 LPhase::~LPhase() { 474 LPhase::~LPhase() {
474 if (ShouldProduceTraceOutput()) { 475 if (ShouldProduceTraceOutput()) {
475 isolate()->GetHTracer()->TraceLithium(name(), chunk_); 476 isolate()->GetHTracer()->TraceLithium(name(), chunk_);
476 } 477 }
477 } 478 }
478 479
479 480
480 } } // namespace v8::internal 481 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/frames.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698