Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 60763006: Replace hard-coded stack frame size literals with StandardFrameConstants::kFixedFrameSizeFromFp (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fix merge error Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/builtins-arm.cc ('k') | src/arm/frames-arm.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 833 matching lines...) Expand 10 before | Expand all | Expand 10 after
844 // following boilerplate stack-building prologue that is found in FUNCTIONS 844 // following boilerplate stack-building prologue that is found in FUNCTIONS
845 static bool initialized = false; 845 static bool initialized = false;
846 static uint32_t sequence[kNoCodeAgeSequenceLength]; 846 static uint32_t sequence[kNoCodeAgeSequenceLength];
847 byte* byte_sequence = reinterpret_cast<byte*>(sequence); 847 byte* byte_sequence = reinterpret_cast<byte*>(sequence);
848 *length = kNoCodeAgeSequenceLength * Assembler::kInstrSize; 848 *length = kNoCodeAgeSequenceLength * Assembler::kInstrSize;
849 if (!initialized) { 849 if (!initialized) {
850 CodePatcher patcher(byte_sequence, kNoCodeAgeSequenceLength); 850 CodePatcher patcher(byte_sequence, kNoCodeAgeSequenceLength);
851 PredictableCodeSizeScope scope(patcher.masm(), *length); 851 PredictableCodeSizeScope scope(patcher.masm(), *length);
852 patcher.masm()->stm(db_w, sp, r1.bit() | cp.bit() | fp.bit() | lr.bit()); 852 patcher.masm()->stm(db_w, sp, r1.bit() | cp.bit() | fp.bit() | lr.bit());
853 patcher.masm()->nop(ip.code()); 853 patcher.masm()->nop(ip.code());
854 patcher.masm()->add(fp, sp, Operand(2 * kPointerSize)); 854 patcher.masm()->add(fp, sp,
855 Operand(StandardFrameConstants::kFixedFrameSizeFromFp));
855 initialized = true; 856 initialized = true;
856 } 857 }
857 return byte_sequence; 858 return byte_sequence;
858 } 859 }
859 860
860 861
861 bool Code::IsYoungSequence(byte* sequence) { 862 bool Code::IsYoungSequence(byte* sequence) {
862 uint32_t young_length; 863 uint32_t young_length;
863 byte* young_sequence = GetNoCodeAgeSequence(&young_length); 864 byte* young_sequence = GetNoCodeAgeSequence(&young_length);
864 bool result = !memcmp(sequence, young_sequence, young_length); 865 bool result = !memcmp(sequence, young_sequence, young_length);
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
897 patcher.masm()->add(r0, pc, Operand(-8)); 898 patcher.masm()->add(r0, pc, Operand(-8));
898 patcher.masm()->ldr(pc, MemOperand(pc, -4)); 899 patcher.masm()->ldr(pc, MemOperand(pc, -4));
899 patcher.masm()->emit_code_stub_address(stub); 900 patcher.masm()->emit_code_stub_address(stub);
900 } 901 }
901 } 902 }
902 903
903 904
904 } } // namespace v8::internal 905 } } // namespace v8::internal
905 906
906 #endif // V8_TARGET_ARCH_ARM 907 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/builtins-arm.cc ('k') | src/arm/frames-arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698