Fix Mac warning in PdfViewer.

Fix Mac warning in PdfViewer.

Move a function only used by code guarded by #ifdef PDF_REPORT inside
guard.

R=edisonn@google.com

Committed: https://code.google.com/p/skia/source/detail?r=12170

[tfarina, 2013-11-06 00:37:27]

which warning is?

Nico, is there a better way to fix this?

[Nico, 2013-11-06 00:38:12]

not lgtm

This looks like a bad warning. Are you building with -Weverything? If so, don't.

[edisonn, 2013-11-06 14:10:05]

https://codereview.chromium.org/60763003/diff/1/experimental/PdfViewer/SkPdfR...
File experimental/PdfViewer/SkPdfReporter.cpp (right):

https://codereview.chromium.org/60763003/diff/1/experimental/PdfViewer/SkPdfR...
experimental/PdfViewer/SkPdfReporter.cpp:23: const char*
getSeverityName(SkPdfIssueSeverity sev) {
Doesn't making the function static resolves the issue?

[scroggo, 2013-11-06 17:50:28]

On 2013/11/06 00:37:27, tfarina wrote:
> which warning is?

/Users/scroggo/cloneSkia/trunk/gyp/../experimental/PdfViewer/SkPdfReporter.cpp:22:13:
error: no previous prototype for function 'getSeverityName'
[-Werror,-Wmissing-prototypes]
const char* getSeverityName(SkPdfIssueSeverity sev) {

On 2013/11/06 00:38:12, Nico (ooo until Nov 12) wrote:
> not lgtm
> 
> This looks like a bad warning. Are you building with -Weverything? If so,
don't.

This is after running

./gyp_skia
make pdfviewer

as Edison's instructions state in
https://docs.google.com/a/google.com/document/d/1GODxv2Nj-QLQczxAqKTxx7wLjasW...

It uses the same warnings that Skia uses in general. If you think this is a bad
warning,
we should have a broader discussion about which warnings to turn into errors in
Skia.
We have numerous places in our tools where we declare a prototype to get around
this
error.

On 2013/11/06 14:10:05, edisonn wrote:
>
https://codereview.chromium.org/60763003/diff/1/experimental/PdfViewer/SkPdfR...
> File experimental/PdfViewer/SkPdfReporter.cpp (right):
> 
>
https://codereview.chromium.org/60763003/diff/1/experimental/PdfViewer/SkPdfR...
> experimental/PdfViewer/SkPdfReporter.cpp:23: const char*
> getSeverityName(SkPdfIssueSeverity sev) {
> Doesn't making the function static resolves the issue?

Actually, making it static gives me another error - unused function. The
function is only
used by code inside #ifdef PDF_REPORT, so I've uploaded a new patch which
instead moves
the function inside the PDF_REPORT guard. It probably should be static as well,
but I'll leave
that alone since building with PDF_REPORT set to true does not work build on my
Mac
anyway.

[edisonn, 2013-11-06 18:00:58]

LGTM

[scroggo, 2013-11-07 18:22:27]

Committed patchset #2 manually as r12170 (presubmit successful).