Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 60763002: Never create HTMLTrackElement when VideoTrack is not enabled (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
Reviewers:
adamk, eseidel
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Never create HTMLTrackElement when VideoTrack is not enabled Generalize wrapperOnlyIfMediaIsAvailable into runtimeEnabled to let audio/video/source depend on Media and track on VideoTrack. Let VideoTrack depend on Media, since it would otherwise become possible to create an HTMLTrackElement with Media disabled. The mediaEnabled setting is set to false by InspectorOverlay and SVGImage, in both cases presumably to prevent any media playback. Accomplish this instead by blocking the media load. BUG=315207 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161402

Patch Set 1 #

Patch Set 2 : consistency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -41 lines) Patch
M Source/build/scripts/make_element_factory.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/templates/ElementFactory.cpp.tmpl View 1 chunk +4 lines, -5 lines 0 comments Download
M Source/build/scripts/templates/ElementWrapperFactory.cpp.tmpl View 2 chunks +5 lines, -6 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLTagNames.in View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTrackElement.cpp View 4 chunks +16 lines, -24 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
7 years, 1 month ago (2013-11-05 21:01:51 UTC) #1
philipj_slow
Handing over to Eric, because Adam says so :)
7 years, 1 month ago (2013-11-05 21:09:09 UTC) #2
philipj_slow
The relevant test is media/svg-as-image-with-media-blocked.html and it still passes.
7 years, 1 month ago (2013-11-05 21:13:56 UTC) #3
eseidel
lgtm AWESOME.
7 years, 1 month ago (2013-11-05 23:28:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/60763002/40001
7 years, 1 month ago (2013-11-05 23:28:17 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-06 00:36:46 UTC) #6
Message was sent while issue was closed.
Change committed as 161402

Powered by Google App Engine
This is Rietveld 408576698