Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Issue 607603003: Mac: Minor fullscreen adjustments. (Closed)

Created:
6 years, 2 months ago by erikchen
Modified:
6 years, 2 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mac: Minor fullscreen adjustments. - In Canonical Fullscreen, the toolbar/tabstrip now slide over the content when the AppKit menu bar is revealed. This prevents a series of fast resizes of the content view, which is janky. - Adjust the z-ordering of the infobar so that it shows in front of the bookmark bar and toolbar in Canonical Fullscreen. - Removed method -isInFullscreenWithOmniboxSliding, as it has the same behavior as -isInAnyFullscreenMode. BUG=413210 Committed: https://crrev.com/c70ce43e9e3416dff51f50bef0fc2d25e88735e3 Cr-Commit-Position: refs/heads/master@{#296832}

Patch Set 1 #

Patch Set 2 : Comments from rsesek. #

Patch Set 3 : Fix presentation mode unit test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -33 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout.mm View 1 2 chunks +17 lines, -12 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_layout_unittest.mm View 1 1 chunk +24 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/presentation_mode_controller_unittest.mm View 1 2 4 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
erikchen
rsesek: Please review.
6 years, 2 months ago (2014-09-25 17:54:39 UTC) #2
Robert Sesek
Patched this in, yes this is much better. LGTM
6 years, 2 months ago (2014-09-25 18:10:00 UTC) #3
Robert Sesek
Also, do any tests need to be updated?
6 years, 2 months ago (2014-09-25 18:10:19 UTC) #4
erikchen
rsesek: No response expected. Added a unit test. Removed a method which had the same ...
6 years, 2 months ago (2014-09-25 20:29:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607603003/20001
6 years, 2 months ago (2014-09-25 20:31:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/17607)
6 years, 2 months ago (2014-09-25 22:19:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607603003/40001
6 years, 2 months ago (2014-09-25 23:02:53 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as b3b1dacc2cf56c6652b5a83acb5a2009575d3acc
6 years, 2 months ago (2014-09-25 23:39:36 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 23:40:13 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c70ce43e9e3416dff51f50bef0fc2d25e88735e3
Cr-Commit-Position: refs/heads/master@{#296832}

Powered by Google App Engine
This is Rietveld 408576698