Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 607603002: [Athena] Tempolarily exclude extensions API that are causing crash on Athena (Closed)

Created:
6 years, 2 months ago by oshima
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou, sky
CC:
chromium-reviews, extensions-reviews_chromium.org, posciak+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, chromium-apps-reviews_chromium.org, wjia+watch_chromium.org, pkotwicz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Tempolarily exclude extensions API that are causing crash on Athena I'll fix issues and add them back. BUG=414340 Committed: https://crrev.com/2a244c81663940528ba86dd7515f3ce5e7341e6f Cr-Commit-Position: refs/heads/master@{#296854}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -27 lines) Patch
M chrome/browser/extensions/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/browser_context_keyed_service_factories.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 5 chunks +29 lines, -20 lines 0 comments Download
M chrome/common/extensions/api/schemas.gni View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 1 5 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
oshima
yoz -> chrome/browser/extensions, chrome/common/extensions sky -> chrome/browser pkotwicz -> fyi
6 years, 2 months ago (2014-09-25 22:41:18 UTC) #7
Yoyo Zhou
LGTM
6 years, 2 months ago (2014-09-25 22:55:35 UTC) #8
sky
LGTM
6 years, 2 months ago (2014-09-25 23:41:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607603002/100001
6 years, 2 months ago (2014-09-26 00:46:32 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:100001) as 07755cf70412c093fba7cfa755ded55fc93b3a0a
6 years, 2 months ago (2014-09-26 01:53:45 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 01:54:17 UTC) #13
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/2a244c81663940528ba86dd7515f3ce5e7341e6f
Cr-Commit-Position: refs/heads/master@{#296854}

Powered by Google App Engine
This is Rietveld 408576698