Issue 6076008: Fix regression in upgrade detection in about dialog....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6076008: Fix regression in upgrade detection in about dialog.... (Closed)

Created:
9 years, 11 months ago by grt (UTC plus 2)

Modified:
9 years, 7 months ago

Reviewers:
amit, robertshield

CC:
chromium-reviews, cpu_(ooo_6.6-7.5), huanr, tommi (sloooow) - chröme

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix regression in upgrade detection in about dialog. BUG=67478 TEST=Install SxS, start chrome, open about dialog, notice that it doesn't say to restart if there's no update. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70612

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/views/about_chrome_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

grt (UTC plus 2)

r69433 inadvertently broke the logic in the about dialog. This CL restores the previous behavior.

9 years, 11 months ago (2011-01-06 05:03:32 UTC) #1

robertshield

On 2011/01/06 05:03:32, grt wrote: > r69433 inadvertently broke the logic in the about dialog. ...

9 years, 11 months ago (2011-01-06 11:42:26 UTC) #2

amit

9 years, 11 months ago (2011-01-06 17:57:15 UTC) #3

lg, thanks for fixing this :)

On Thu, Jan 6, 2011 at 3:42 AM, <robertshield@chromium.org> wrote:

> On 2011/01/06 05:03:32, grt wrote:
>
>> r69433 inadvertently broke the logic in the about dialog.  This CL
>> restores
>>
> the
>
>> previous behavior.
>>
>
> LGTM. Good catch!
>
>
> http://codereview.chromium.org/6076008/
>

Expand Messages | Collapse Messages