Issue 6076: Added special case for atomic regular expressions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6076: Added special case for atomic regular expressions. (Closed)

Created:
12 years, 2 months ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Visibility:
Public.

Description

- Case-sensitive atomic regular expressions now use the same code as String.indexOf to do matching. - The --log option is no longer automatically enabled by the other log options.

Patch Set 1 #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+282 lines, -49 lines)			Patch
M	src/jsregexp.h	View	1 chunk	+27 lines, -6 lines	0 comments	Download
M	src/jsregexp.cc	View	4 chunks	+112 lines, -3 lines	0 comments	Download
M	src/log.cc	View	11 chunks	+22 lines, -16 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-debug.cc	View	1 chunk	+13 lines, -1 line	0 comments	Download
M	src/runtime.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	7 chunks	+26 lines, -20 lines	0 comments	Download
M	src/unicode.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/unicode.cc	View	3 chunks	+16 lines, -2 lines	0 comments	Download
A	test/mjsunit/regexp-indexof.js	View	1 chunk	+60 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

12 years, 2 months ago (2008-10-02 13:14:28 UTC) #2

On 2008/10/02 12:00:05, Christian Plesner Hansen wrote:
> 

Seems a little strange that we only use KMP for needles > 100 characters. 
That's probably very rare.

LGTM

Expand Messages | Collapse Messages