Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 607593003: Telemetry: print available page set names when page set is not found (Closed)

Created:
6 years, 2 months ago by Luigi Semenzato
Modified:
6 years, 2 months ago
Reviewers:
ariblue, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Telemetry: print available page set names when page set is not found BUG=None TEST=manual Committed: https://crrev.com/ff4fd649317e2863ce77ab106896ffd95d93aba1 Cr-Commit-Position: refs/heads/master@{#296789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M tools/telemetry/telemetry/test_runner.py View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
Luigi Semenzato
I realize you want to eliminate _MatchPageSetName, but this will help in the meanwhile and ...
6 years, 2 months ago (2014-09-25 17:43:54 UTC) #2
tonyg
I'll rubber stamp when Ari is happy.
6 years, 2 months ago (2014-09-25 17:50:17 UTC) #3
ariblue
On 2014/09/25 17:50:17, tonyg wrote: > I'll rubber stamp when Ari is happy. Yeah, lgtm ...
6 years, 2 months ago (2014-09-25 17:51:04 UTC) #4
Luigi Semenzato
On 2014/09/25 17:51:04, ariblue wrote: > On 2014/09/25 17:50:17, tonyg wrote: > > I'll rubber ...
6 years, 2 months ago (2014-09-25 17:54:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607593003/1
6 years, 2 months ago (2014-09-25 17:55:59 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-09-25 17:56:01 UTC) #9
Luigi Semenzato
On 2014/09/25 17:56:01, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 2 months ago (2014-09-25 18:01:05 UTC) #10
Luigi Semenzato
On 2014/09/25 18:01:05, Luigi Semenzato wrote: > On 2014/09/25 17:56:01, I haz the power (commit-bot) ...
6 years, 2 months ago (2014-09-25 18:02:12 UTC) #11
tonyg
lgtm
6 years, 2 months ago (2014-09-25 18:16:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607593003/1
6 years, 2 months ago (2014-09-25 18:17:05 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6bf1760b839663596043de9c2a6638c7952751cf
6 years, 2 months ago (2014-09-25 20:51:35 UTC) #15
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 20:52:07 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff4fd649317e2863ce77ab106896ffd95d93aba1
Cr-Commit-Position: refs/heads/master@{#296789}

Powered by Google App Engine
This is Rietveld 408576698