[Android] Fix UIAutomator test running.

[Android] Fix UIAutomator test running.

I broke the uiautomator tests with my change to instrumentation test
running in https://codereview.chromium.org/558883003/. The revised
implementation never called _RunTest, which the uiautomator test runner
overrides to run its tests. As a result, we were trying to run the
uiautomator tests with 'am instrument', which (obviously) doesn't work.

This patch revises the implementation of the instrumentation test runner
s.t. it does call _RunTest again.

BUG=417492
Committed: https://crrev.com/10a670535f86258e35633d855a01dac0a3f11c51
Cr-Commit-Position: refs/heads/master@{#296835}

[jbudorick, 2014-09-25 17:07:41]

jbudorick@chromium.org changed reviewers:
+ klundberg@chromium.org, mikecase@chromium.org

[mikecase (-- gone --), 2014-09-25 17:33:52]

On 2014/09/25 17:07:41, jbudorick wrote:

lgtm

[klundberg, 2014-09-25 17:50:58]

Lgtm but could you please update the commit message (my preference) or the bug
with information about why this broke?

[jbudorick, 2014-09-25 19:52:59]

On 2014/09/25 17:50:58, klundberg wrote:
> Lgtm but could you please update the commit message (my preference) or the bug
> with information about why this broke?

Done.

[jbudorick, 2014-09-25 19:53:14]

jbudorick@chromium.org changed reviewers:
+ craigdh@chromium.org

[jbudorick, 2014-09-25 19:53:15]

+craigdh for rslgtm

[craigdh, 2014-09-25 19:59:47]

lgtm w/ comment that you really ought to address

https://codereview.chromium.org/607583002/diff/20001/build/android/pylib/inst...
File build/android/pylib/instrumentation/test_runner.py (right):

https://codereview.chromium.org/607583002/diff/20001/build/android/pylib/inst...
build/android/pylib/instrumentation/test_runner.py:508: if isinstance(e,
device_errors.CommandTimeoutError):
Handle different error types by having multiple except: blocks, not by using
isinstance. This is a bit messy.

[jbudorick, 2014-09-25 20:07:00]

https://codereview.chromium.org/607583002/diff/20001/build/android/pylib/inst...
File build/android/pylib/instrumentation/test_runner.py (right):

https://codereview.chromium.org/607583002/diff/20001/build/android/pylib/inst...
build/android/pylib/instrumentation/test_runner.py:508: if isinstance(e,
device_errors.CommandTimeoutError):
On 2014/09/25 19:59:47, craigdh wrote:
> Handle different error types by having multiple except: blocks, not by using
> isinstance. This is a bit messy.

I was between the two, since the code is otherwise the same. Switched.

[jbudorick, 2014-09-25 20:07:16]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-09-25 20:08:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/607583002/40001

[craigdh, 2014-09-25 20:12:10]

https://codereview.chromium.org/607583002/diff/40001/build/android/pylib/inst...
File build/android/pylib/instrumentation/test_runner.py (right):

https://codereview.chromium.org/607583002/diff/40001/build/android/pylib/inst...
build/android/pylib/instrumentation/test_runner.py:505: message = 'No
information'
well, you could skip these duplicated lines by just doing "log=message if
message else 'No information" in the results.AddResult

[jbudorick, 2014-09-25 20:14:50]

The CQ bit was unchecked by jbudorick@chromium.org

[jbudorick, 2014-09-25 20:24:51]

https://codereview.chromium.org/607583002/diff/40001/build/android/pylib/inst...
File build/android/pylib/instrumentation/test_runner.py (right):

https://codereview.chromium.org/607583002/diff/40001/build/android/pylib/inst...
build/android/pylib/instrumentation/test_runner.py:505: message = 'No
information'
On 2014/09/25 20:12:10, craigdh wrote:
> well, you could skip these duplicated lines by just doing "log=message if
> message else 'No information" in the results.AddResult

changed to log=str(e) or 'No information'

[jbudorick, 2014-09-25 20:27:55]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-09-25 20:29:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/607583002/60001

[commit-bot: I haz the power, 2014-09-25 23:54:57]

Committed patchset #4 (id:60001) as fc81feee38f201c7d881f29af866a0edce06c3ee

[commit-bot: I haz the power, 2014-09-25 23:55:34]

Patchset 4 (id:??) landed as
https://crrev.com/10a670535f86258e35633d855a01dac0a3f11c51
Cr-Commit-Position: refs/heads/master@{#296835}