Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Side by Side Diff: chrome/browser/safe_browsing/srt_global_error_win.cc

Issue 607573002: Small fixes to SRTPRompt. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved histograms.xml to another CL, and added a histogram rename. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/component_updater/sw_reporter_installer_win.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/srt_global_error_win.h" 5 #include "chrome/browser/safe_browsing/srt_global_error_win.h"
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/metrics/histogram.h" 8 #include "base/metrics/histogram.h"
9 #include "chrome/app/chrome_command_ids.h" 9 #include "chrome/app/chrome_command_ids.h"
10 #include "chrome/browser/ui/browser.h" 10 #include "chrome/browser/ui/browser.h"
(...skipping 12 matching lines...) Expand all
23 // to the end, before SRT_PROMPT_MAX, of course. 23 // to the end, before SRT_PROMPT_MAX, of course.
24 enum SRTPromptHistogramValue { 24 enum SRTPromptHistogramValue {
25 SRT_PROMPT_SHOWN = 0, 25 SRT_PROMPT_SHOWN = 0,
26 SRT_PROMPT_ACCEPTED = 1, 26 SRT_PROMPT_ACCEPTED = 1,
27 SRT_PROMPT_DENIED = 2, 27 SRT_PROMPT_DENIED = 2,
28 28
29 SRT_PROMPT_MAX, 29 SRT_PROMPT_MAX,
30 }; 30 };
31 31
32 void RecordSRTPromptHistogram(SRTPromptHistogramValue value) { 32 void RecordSRTPromptHistogram(SRTPromptHistogramValue value) {
33 UMA_HISTOGRAM_ENUMERATION("SRTPrompt", value, SRT_PROMPT_MAX); 33 UMA_HISTOGRAM_ENUMERATION(
34 "SoftwareReporter.PromptUsage", value, SRT_PROMPT_MAX);
34 } 35 }
35 36
36 } // namespace 37 } // namespace
37 38
38 // SRTGlobalError ------------------------------------------------------------ 39 // SRTGlobalError ------------------------------------------------------------
39 40
40 SRTGlobalError::SRTGlobalError(GlobalErrorService* global_error_service) 41 SRTGlobalError::SRTGlobalError(GlobalErrorService* global_error_service)
41 : global_error_service_(global_error_service) { 42 : global_error_service_(global_error_service) {
42 DCHECK(global_error_service_); 43 DCHECK(global_error_service_);
43 } 44 }
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 104
104 void SRTGlobalError::BubbleViewCancelButtonPressed(Browser* browser) { 105 void SRTGlobalError::BubbleViewCancelButtonPressed(Browser* browser) {
105 RecordSRTPromptHistogram(SRT_PROMPT_DENIED); 106 RecordSRTPromptHistogram(SRT_PROMPT_DENIED);
106 DismissGlobalError(); 107 DismissGlobalError();
107 } 108 }
108 109
109 void SRTGlobalError::DismissGlobalError() { 110 void SRTGlobalError::DismissGlobalError() {
110 global_error_service_->RemoveGlobalError(this); 111 global_error_service_->RemoveGlobalError(this);
111 delete this; 112 delete this;
112 } 113 }
OLDNEW
« no previous file with comments | « chrome/browser/component_updater/sw_reporter_installer_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698