Issue 607543002: Add nacl_helper to interactive_ui_tests' isolate to make LoggedInSpokenFeedbackTest.AddBookmark pas…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 607543002: Add nacl_helper to interactive_ui_tests' isolate to make LoggedInSpokenFeedbackTest.AddBookmark pas… (Closed)

Created:
6 years, 2 months ago by jam

Modified:
6 years, 2 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add nacl_helper to interactive_ui_tests' isolate to make LoggedInSpokenFeedbackTest.AddBookmark pass. BUG=414808 TBR=dmazzoni@chromium.org Committed: https://crrev.com/fe3e9c08535896b6df71a685f495711aa2bca872 Cr-Commit-Position: refs/heads/master@{#296708}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/interactive_ui_tests.isolate	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/fe3e9c08535896b6df71a685f495711aa2bca872 Cr-Commit-Position: refs/heads/master@{#296708}

6 years, 2 months ago (2014-09-25 14:55:46 UTC) #2

jam

Committed patchset #1 (id:1) manually as fe3e9c0 (presubmit successful).

6 years, 2 months ago (2014-09-25 14:55:46 UTC) #3

dmazzoni

Thank you! I don't see any 32-bit tests failing, but for symmetry and futureproofing should ...

6 years, 2 months ago (2014-09-25 15:13:30 UTC) #4

jam

6 years, 2 months ago (2014-09-25 16:36:41 UTC) #5

Message was sent while issue was closed.

On 2014/09/25 15:13:30, dmazzoni wrote:
> Thank you!
> 
> I don't see any 32-bit tests failing, but for symmetry and futureproofing
should
> we add nacl_irt_x86_32.nexe too?

I guess we would need it if we had 32 bit CrOS tests running on swarming. AFAIK
we don't have 32 bit swarmed machines. So yes for future proofing we can add it,
although if/when we start swarming 32 bit this (and other missing files) would
quickly come to light, so I'm leaning towards not doing anything till then.

Expand Messages | Collapse Messages