LayoutTests/storage/indexeddb/resources/transaction-complete-workers.js - Issue 607513002: Onerror return value handling in workers fixed as per HTML5 spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/storage/indexeddb/resources/transaction-complete-workers.js

Issue 607513002: Onerror return value handling in workers fixed as per HTML5 spec. Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added new layout tests and rebaselined two of them. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/workers/worker-onerror-04-expected.txt ('K') | « LayoutTests/fast/workers/worker-onerror-04-expected.txt ('k') | LayoutTests/storage/indexeddb/transaction-complete-workers-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/storage/indexeddb/resources/transaction-complete-workers.js

diff --git a/LayoutTests/storage/indexeddb/resources/transaction-complete-workers.js b/LayoutTests/storage/indexeddb/resources/transaction-complete-workers.js

index 48f5731c1209131dce32b02d6bbd86beefcd5665..883667c95dc36f1574785978446b01775f94dca2 100644

--- a/LayoutTests/storage/indexeddb/resources/transaction-complete-workers.js

+++ b/LayoutTests/storage/indexeddb/resources/transaction-complete-workers.js

@@ -105,6 +105,11 @@ function errorHandler(e)

transaction.onerror = unexpectedErrorCallback;

transaction.onabort = unexpectedAbortCallback;

transaction.oncomplete = errorTransactionCompleted;

+ // We will cancel the error event here itself,

+ // this will allow the transaction to complete.

+ // Thus the event.preventDefault in the worker.onerror

+ // is no longer required in this scenario.

+ return true;

}

function errorTransactionCompleted()