Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Unified Diff: public/platform/WebMediaPlayer.h

Issue 607493002: Introduce WebMediaPlayer::seekable() to replace maxTimeSeekable() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLMediaElement.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebMediaPlayer.h
diff --git a/public/platform/WebMediaPlayer.h b/public/platform/WebMediaPlayer.h
index ee003b57a9e7e6e4a73fb573024e7c0b9520b56e..204eb52b6b444d1da952f6672e3a639a7e707115 100644
--- a/public/platform/WebMediaPlayer.h
+++ b/public/platform/WebMediaPlayer.h
@@ -114,7 +114,17 @@ public:
virtual void requestRemotePlaybackControl() { };
virtual void setPreload(Preload) { };
virtual WebTimeRanges buffered() const = 0;
- virtual double maxTimeSeekable() const = 0;
+ virtual WebTimeRanges seekable() const
scherkus (not reviewing) 2014/09/26 01:19:27 I assume we'll be ripping this out at some point?
philipj_slow 2014/09/26 07:39:26 Yep, that's https://codereview.chromium.org/604823
+ {
+ if (double end = maxTimeSeekable()) {
+ WebTimeRanges ranges(static_cast<size_t>(1));
+ ranges[0].start = 0.0;
+ ranges[0].end = end;
+ return ranges;
+ }
+ return WebTimeRanges();
+ }
+ virtual double maxTimeSeekable() const { return 0.0; }
// True if the loaded media has a playable video/audio track.
virtual bool hasVideo() const = 0;
« no previous file with comments | « Source/core/html/HTMLMediaElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698