Source/core/rendering/svg/SVGTextRunRenderingContext.cpp - Issue 607483002: Separate advance from offset in GlypBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

Issue 607483002: Separate advance from offset in GlypBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressing Dominik's comments Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

diff --git a/Source/core/rendering/svg/SVGTextRunRenderingContext.cpp b/Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

index 45b4e297044e56c6a9d2a549dea216adf7d192fa..ec9aa0ff6319edd4a323530764d6693fce7f7c9f 100644

--- a/Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

+++ b/Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

@@ -113,7 +113,7 @@ void SVGTextRunRenderingContext::drawSVGGlyphs(GraphicsContext* context, const T

if (!glyph)

continue;

- float advance = glyphBuffer.advanceAt(from + i).width();

+ float advance = glyphBuffer.advanceAt(from + i);

SVGGlyph svgGlyph = fontElement->svgGlyphForGlyph(glyph);

ASSERT(!svgGlyph.isPartOfLigature);

ASSERT(svgGlyph.tableEntry == glyph);