Android Chromoting: Don't fetch auth token if there's a fetch pending.

Android Chromoting: Don't fetch auth token if there's a fetch pending.

Currently, the host list is fetched from the main activity's onStart()
handler. If onStart() is triggered again during the process of
authentication, this could cause an infinite loop of pending requests.

Committed: https://crrev.com/f1318ecbfff840702b08eab40d744dc55670610d
Cr-Commit-Position: refs/heads/master@{#297088}

[Lambros, 2014-09-26 21:20:21]

lambroslambrou@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[Jamie, 2014-09-26 21:31:17]

https://codereview.chromium.org/607453004/diff/1/remoting/android/java/src/or...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right):

https://codereview.chromium.org/607453004/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:409:
requestAuthToken();
Does this not also need to be guarded against reentry?

[Lambros, 2014-09-26 22:36:34]

https://codereview.chromium.org/607453004/diff/1/remoting/android/java/src/or...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right):

https://codereview.chromium.org/607453004/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:409:
requestAuthToken();
On 2014/09/26 21:31:17, Jamie wrote:
> Does this not also need to be guarded against reentry?

No, because we've got the token at this point, so there's no longer a pending
token. Note that mWaitingForAuthToken is set to false at the top of this method.

[Jamie, 2014-09-27 00:01:29]

lgtm

[Lambros, 2014-09-27 00:03:56]

The CQ bit was checked by lambroslambrou@chromium.org

[commit-bot: I haz the power, 2014-09-27 00:05:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/607453004/1

[commit-bot: I haz the power, 2014-09-27 01:12:52]

Committed patchset #1 (id:1) as 2abdb4711198d08e9820e48a9e909c66a08eaf2c

[commit-bot: I haz the power, 2014-09-27 01:13:23]

Patchset 1 (id:??) landed as
https://crrev.com/f1318ecbfff840702b08eab40d744dc55670610d
Cr-Commit-Position: refs/heads/master@{#297088}