Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: src/PNaClTranslator.cpp

Issue 607443003: Subzero: Enable the C++11 build. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/PNaClTranslator.cpp
diff --git a/src/PNaClTranslator.cpp b/src/PNaClTranslator.cpp
index 35108ccc560410fcb01575c3b3b65144b50c883e..eeecdda2ed5d539416d1736ed92316a9247fb5c3 100644
--- a/src/PNaClTranslator.cpp
+++ b/src/PNaClTranslator.cpp
@@ -66,8 +66,7 @@ public:
setErrStream(Translator.getContext()->getStrDump());
}
- virtual ~TopLevelParser() {}
- LLVM_OVERRIDE;
JF 2014/09/25 20:57:07 This should be: ~TopLevelParser() override {} N
Jim Stichnoth 2014/09/26 00:11:17 Done.
+ virtual ~TopLevelParser() LLVM_OVERRIDE {}
Ice::Translator &getTranslator() { return Translator; }
@@ -2287,7 +2286,7 @@ void ModuleValuesymtabParser::setBbName(uint64_t Index, StringType &Name) {
Error(StrBuf.str());
}
-bool ModuleParser::ParseBlock(unsigned BlockID) LLVM_OVERRIDE {
JF 2014/09/25 20:57:07 This should be override. Or does it not override (
Jim Stichnoth 2014/09/26 00:11:17 The override is already provided in the class defi
+bool ModuleParser::ParseBlock(unsigned BlockID) {
switch (BlockID) {
case naclbitc::BLOCKINFO_BLOCK_ID:
return NaClBitcodeParser::ParseBlock(BlockID);
« no previous file with comments | « src/IceTypeConverter.cpp ('k') | src/assembler_ia32.h » ('j') | src/assembler_ia32.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698