Subzero: Enable the C++11 build.

Subzero: Enable the C++11 build.

This just adds -std=c++11 to the compiler flags and fixes the resulting errors/warnings.

Later CLs can fix things related to the LLVM 3.5 merge.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3930
R=jfb@chromium.org, kschimpf@google.com

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8e8042c42b71675891b824b6bfcd8938174661bc

[Jim Stichnoth, 2014-09-25 20:31:49]

stichnot@chromium.org changed reviewers:
+ jfb@chromium.org, jvoung@chromium.org, kschimpf@google.com

[JF, 2014-09-25 20:57:07]

For posterity, this is a fork of:
  https://codereview.chromium.org/512933006/

Explanation of the move ctor change:

Variable's copy ctor is deleted and Variable::asType returns a Variable. That
used to work because of return value optimization and doesn't work anymore
because the implicitly-declared move ctor is getting deleted (because at least
one data member, IceString, isn't trivially copyable). This wouldn't be a
problem in C++14, but it is in C++11, the implicitly declared move ctor
therefore needs to be force-generated by marking it with '= default'.

https://codereview.chromium.org/607443003/diff/1/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (left):

https://codereview.chromium.org/607443003/diff/1/src/PNaClTranslator.cpp#oldc...
src/PNaClTranslator.cpp:70: LLVM_OVERRIDE;
This should be:

~TopLevelParser() override {}


No virtual.

https://codereview.chromium.org/607443003/diff/1/src/PNaClTranslator.cpp#oldc...
src/PNaClTranslator.cpp:2290: bool ModuleParser::ParseBlock(unsigned BlockID)
LLVM_OVERRIDE {
This should be override. Or does it not override (and is that intentional?).

[Karl, 2014-09-25 20:59:33]

Fix the override cases (as suggested by JF). Otherwise LGTM.

[jvoung (off chromium), 2014-09-25 21:05:01]

https://codereview.chromium.org/607443003/diff/1/src/assembler_ia32.h
File src/assembler_ia32.h (right):

https://codereview.chromium.org/607443003/diff/1/src/assembler_ia32.h#newcode161
src/assembler_ia32.h:161: // uint8_t padding_;
I think that we might as well delete this.

[Jim Stichnoth, 2014-09-26 00:11:18]

There will be a lot of changes to add "override" everywhere else, but I think
that can be done in a separate CL.

https://codereview.chromium.org/607443003/diff/1/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (left):

https://codereview.chromium.org/607443003/diff/1/src/PNaClTranslator.cpp#oldc...
src/PNaClTranslator.cpp:70: LLVM_OVERRIDE;
On 2014/09/25 20:57:07, JF wrote:
> This should be:
> 
> ~TopLevelParser() override {}
> 
> 
> No virtual.

Done.

https://codereview.chromium.org/607443003/diff/1/src/PNaClTranslator.cpp#oldc...
src/PNaClTranslator.cpp:2290: bool ModuleParser::ParseBlock(unsigned BlockID)
LLVM_OVERRIDE {
On 2014/09/25 20:57:07, JF wrote:
> This should be override. Or does it not override (and is that intentional?).

The override is already provided in the class definition above.  Putting it on
the method definition outside the class definition seems to be an error.

https://codereview.chromium.org/607443003/diff/1/src/assembler_ia32.h
File src/assembler_ia32.h (right):

https://codereview.chromium.org/607443003/diff/1/src/assembler_ia32.h#newcode161
src/assembler_ia32.h:161: // uint8_t padding_;
On 2014/09/25 21:05:01, jvoung wrote:
> I think that we might as well delete this.

Done.

[JF, 2014-09-26 00:47:27]

lgtm

[Jim Stichnoth, 2014-09-26 00:51:50]

Committed patchset #2 (id:20001) manually as 8e8042c (presubmit successful).