Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 60733023: Remove TreatNullAs=NullString for HTMLFormElement (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
blink-reviews, dglazkov+blink, arv+blink, Inactive, adamk+blink_chromium.org
Visibility:
Public.

Description

Remove TreatNullAs=NullString for HTMLFormElement http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#htmlformelement The tests for the updated properties pass in Firefox Nightly, IE11 Release Preview and Opera 12.16, with these exceptions: Firefox reflects autocomplete as 'on', which is per spec since autocomplete is an enumerated attribute, but this will not be fixed in Blink as part of this change. IE11 throws an exception for enctype, encoding and method. Opera doesn't support autocomplete and reflects encoding as 'null'. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162029

Patch Set 1 #

Patch Set 2 : update test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -21 lines) Patch
M LayoutTests/fast/dom/domstring-attribute-reflection.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/domstring-attribute-reflection-expected.txt View 1 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null.html View 1 chunk +6 lines, -5 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 chunk +6 lines, -5 lines 0 comments Download
M Source/core/html/HTMLFormElement.idl View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
7 years, 1 month ago (2013-11-14 10:06:53 UTC) #1
jochen (gone - plz use gerrit)
the trybots don't like your change?
7 years, 1 month ago (2013-11-14 11:49:03 UTC) #2
philipj_slow
On 2013/11/14 11:49:03, jochen wrote: > the trybots don't like your change? Fixed the failing ...
7 years, 1 month ago (2013-11-14 12:13:24 UTC) #3
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-14 12:17:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/60733023/60001
7 years, 1 month ago (2013-11-14 13:10:52 UTC) #5
commit-bot: I haz the power
Failed to apply patch for LayoutTests/fast/dom/domstring-attribute-reflection.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 1 month ago (2013-11-14 13:10:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/60733023/60001
7 years, 1 month ago (2013-11-14 14:13:39 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-14 15:35:55 UTC) #8
Message was sent while issue was closed.
Change committed as 162029

Powered by Google App Engine
This is Rietveld 408576698