Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3643)

Unified Diff: chrome/browser/sync/profile_sync_service_autofill_unittest.cc

Issue 60733019: This is the third CL of several that will eventually replace TokenService with (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/profile_sync_service.cc ('k') | chrome/browser/sync/profile_sync_service_harness.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_service_autofill_unittest.cc
diff --git a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
index 575c71464b345f6591760cb75bdd33dbcca673d0..3357b1261962d65ee51e1edfb67e9da4c18b2819 100644
--- a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
+++ b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
@@ -23,7 +23,6 @@
#include "chrome/browser/autofill/personal_data_manager_factory.h"
#include "chrome/browser/signin/signin_manager.h"
#include "chrome/browser/signin/signin_manager_factory.h"
-#include "chrome/browser/signin/token_service_factory.h"
#include "chrome/browser/sync/abstract_profile_sync_service_test.h"
#include "chrome/browser/sync/fake_oauth2_token_service.h"
#include "chrome/browser/sync/glue/autofill_data_type_controller.h"
@@ -202,12 +201,12 @@ class TokenWebDataServiceFake : public TokenWebData {
virtual WebDataService::Handle GetAllTokens(
WebDataServiceConsumer* consumer) OVERRIDE {
// TODO(tim): It would be nice if WebDataService was injected on
- // construction of TokenService rather than fetched by Initialize so that
- // this isn't necessary (we could pass a NULL service). We currently do
- // return it via EXPECT_CALLs, but without depending on order-of-
- // initialization (which seems way more fragile) we can't tell which
- // component is asking at what time, and some components in these Autofill
- // tests require a WebDataService.
+ // construction of ProfileOAuth2TokenService rather than fetched by
+ // Initialize so that this isn't necessary (we could pass a NULL service).
+ // We currently do return it via EXPECT_CALLs, but without depending on
+ // order-of-initialization (which seems way more fragile) we can't tell
+ // which component is asking at what time, and some components in these
+ // Autofill tests require a WebDataService.
return 0;
}
@@ -526,9 +525,6 @@ class ProfileSyncServiceAutofillTest
personal_data_manager_ =
personal_data_manager_service->GetPersonalDataManager();
- token_service_ = static_cast<TokenService*>(
- TokenServiceFactory::GetInstance()->SetTestingFactoryAndUse(
- profile_.get(), BuildTokenService));
EXPECT_CALL(*personal_data_manager_, LoadProfiles()).Times(1);
EXPECT_CALL(*personal_data_manager_, LoadCreditCards()).Times(1);
« no previous file with comments | « chrome/browser/sync/profile_sync_service.cc ('k') | chrome/browser/sync/profile_sync_service_harness.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698