Issue 60733019: This is the third CL of several that will eventually replace TokenService with

Issue 60733019: This is the third CL of several that will eventually replace TokenService with (Closed)

Created:
7 years, 1 month ago by Roger Tawa OOO till Jul 10th

Modified:
7 years, 1 month ago

Reviewers:
pavely, tim (not reviewing)

CC:
chromium-reviews, tim+watch_chromium.org, cbentzel+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

This is the third CL of several that will eventually replace TokenService with ProfileOAuth2TokenService. In this CL, the dependencies on TS are removed from profile sync service. BUG=305247 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235870

Patch Set 1 #

Patch Set 2 : Fix condition in ProfileSyncService::TryStart() #

Patch Set 3 : rebased #

Patch Set 4 : Fix sync int tests: issue token #

Patch Set 5 : rebased #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -94 lines)			Patch
M	chrome/browser/invalidation/ticl_invalidation_service.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/net/gaia/gaia_oauth_fetcher.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/abstract_profile_sync_service_test.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/abstract_profile_sync_service_test.cc	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	1	4 chunks	+7 lines, -16 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_autofill_unittest.cc	View		3 chunks	+6 lines, -10 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_harness.cc	View	1 2 3	3 chunks	+16 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_password_unittest.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_preference_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service_session_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/sync/profile_sync_service_startup_unittest.cc	View		8 chunks	+8 lines, -37 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_typed_url_unittest.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/sync/test_profile_sync_service.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Roger Tawa OOO till Jul 10th

Hi Pavel, Tim, Please take a look. Thanks.

7 years, 1 month ago (2013-11-13 20:40:25 UTC) #1

pavely

On 2013/11/13 20:40:25, Roger Tawa wrote: > Hi Pavel, Tim, > > Please take a ...

7 years, 1 month ago (2013-11-16 02:05:15 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/60733019/790001

7 years, 1 month ago (2013-11-18 20:05:46 UTC) #4

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=226060

7 years, 1 month ago (2013-11-18 23:30:50 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/60733019/790001

7 years, 1 month ago (2013-11-18 23:35:52 UTC) #6

Message was sent while issue was closed.

Change committed as 235870

Expand Messages | Collapse Messages