Suppress the logging spams caused by page_runner_unittests.

Suppress the logging spam caused by page_runner_unittests.

BUG=

Committed: https://crrev.com/d0f39d853114654668a9e739823d005a6c7f5ac3
Cr-Commit-Position: refs/heads/master@{#297487}

[nednguyen, 2014-09-27 16:08:40]

Patchset #1 (id:1) has been deleted

[nednguyen, 2014-09-29 17:15:34]

Patchset #1 (id:20001) has been deleted

[nednguyen, 2014-09-29 18:27:56]

nednguyen@google.com changed reviewers:
+ chrishenry@google.com, dtu@chromium.org, tonyg@chromium.org

[tonyg, 2014-09-29 18:29:54]

/me defers to Dave on this review.

[nednguyen, 2014-09-29 18:30:07]

On 2014/09/29 18:27:57, nednguyen wrote:

Before:
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...

After:
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...

[dtu, 2014-09-29 19:14:42]

Alternative idea: move the exception printing from page_runner to
ProgressReporter, on DidRunPage. I think the page_runner_unittests already run
with no ProgressReporter to suppress the GTest output.

[chrishenry, 2014-09-29 19:38:23]

On 2014/09/29 19:14:42, dtu wrote:
> Alternative idea: move the exception printing from page_runner to
> ProgressReporter, on DidRunPage. I think the page_runner_unittests already run
> with no ProgressReporter to suppress the GTest output.

+1
We can move them to benchmark-level/page-level failure, like what slamm is
trying to do in his patch (586473003). That way, we can rely on stubbing
ProgressReporter interface, and we can test the content of PageTestResults
instead.

[nednguyen, 2014-09-29 20:44:10]

On 2014/09/29 19:38:23, chrishenry wrote:
> On 2014/09/29 19:14:42, dtu wrote:
> > Alternative idea: move the exception printing from page_runner to
> > ProgressReporter, on DidRunPage. I think the page_runner_unittests already
run
> > with no ProgressReporter to suppress the GTest output.
> 
> +1
> We can move them to benchmark-level/page-level failure, like what slamm is
> trying to do in his patch (586473003). That way, we can rely on stubbing
> ProgressReporter interface, and we can test the content of PageTestResults
> instead.

Hmh, actually I think we don't need this
exception_formatter.PrintFormattedException

[chrishenry, 2014-09-30 19:07:55]

lgtm. Fine to submit as it is, but can you file a bug to switch us to always
report failures to PageTestResults?

[nednguyen, 2014-09-30 19:55:32]

On 2014/09/30 19:07:55, chrishenry wrote:
> lgtm. Fine to submit as it is, but can you file a bug to switch us to always
> report failures to PageTestResults?

https://code.google.com/p/chromium/issues/detail?id=418771

[nednguyen, 2014-09-30 19:55:35]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-09-30 19:57:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/607273002/40001

[commit-bot: I haz the power, 2014-09-30 20:03:40]

Committed patchset #1 (id:40001) as 7c48f6c54d17c109025b80c068159a524e1f5791

[commit-bot: I haz the power, 2014-09-30 20:04:36]

Patchset 1 (id:??) landed as
https://crrev.com/d0f39d853114654668a9e739823d005a6c7f5ac3
Cr-Commit-Position: refs/heads/master@{#297487}

[chrishenry, 2014-09-30 20:20:21]

Filed crbug.com/419103 for the broader failure-reporting issues.