Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 607183002: [Fixed] [Suggestions] Move ImageManager to the component (Closed)

Created:
6 years, 2 months ago by Mathieu
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang, huangs, blundell
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Fixed] [Suggestions] Move ImageManager to the component One (1!) line fix to remove Valgrind issue. Original review https://codereview.chromium.org/543753002/ Keeps the fetcher functionality as ImageFetcherImpl in chrome/browser/search/suggestions. BUG=387751 TBR=blundell TEST=ImageManagerTest,ImageFetcherBrowserTest Committed: https://crrev.com/c3c8b0ee0631eca2eb313f2be2f68edf772e6ef9 Cr-Commit-Position: refs/heads/master@{#297177}

Patch Set 1 #

Patch Set 2 : Fixed valgrind issue #

Patch Set 3 : 4 x 4 bitmap #

Total comments: 4

Patch Set 4 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+762 lines, -902 lines) Patch
A chrome/browser/search/suggestions/image_fetcher_impl.h View 1 chunk +84 lines, -0 lines 0 comments Download
A chrome/browser/search/suggestions/image_fetcher_impl.cc View 1 chunk +82 lines, -0 lines 0 comments Download
A chrome/browser/search/suggestions/image_fetcher_impl_browsertest.cc View 1 chunk +149 lines, -0 lines 0 comments Download
D chrome/browser/search/suggestions/image_manager_impl.h View 1 chunk +0 lines, -170 lines 0 comments Download
D chrome/browser/search/suggestions/image_manager_impl.cc View 1 chunk +0 lines, -278 lines 0 comments Download
D chrome/browser/search/suggestions/image_manager_impl_browsertest.cc View 1 chunk +0 lines, -277 lines 0 comments Download
D chrome/browser/search/suggestions/image_manager_impl_unittest.cc View 1 chunk +0 lines, -64 lines 0 comments Download
M chrome/browser/search/suggestions/suggestions_service_factory.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/suggestions.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M components/suggestions/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M components/suggestions/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A components/suggestions/image_fetcher.h View 1 chunk +34 lines, -0 lines 0 comments Download
A components/suggestions/image_fetcher_delegate.h View 1 chunk +29 lines, -0 lines 0 comments Download
M components/suggestions/image_manager.h View 1 chunk +125 lines, -10 lines 0 comments Download
A + components/suggestions/image_manager.cc View 1 2 3 12 chunks +43 lines, -93 lines 0 comments Download
A components/suggestions/image_manager_unittest.cc View 1 2 3 1 chunk +196 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Lei Zhang
https://codereview.chromium.org/607183002/diff/40001/components/suggestions/image_manager.cc File components/suggestions/image_manager.cc (right): https://codereview.chromium.org/607183002/diff/40001/components/suggestions/image_manager.cc#newcode225 components/suggestions/image_manager.cc:225: bitmap.width() * bitmap.bytesPerPixel(), 100, dest); BTW, you can use ...
6 years, 2 months ago (2014-09-26 19:27:37 UTC) #3
Mathieu
Thanks! https://codereview.chromium.org/607183002/diff/40001/components/suggestions/image_manager.cc File components/suggestions/image_manager.cc (right): https://codereview.chromium.org/607183002/diff/40001/components/suggestions/image_manager.cc#newcode225 components/suggestions/image_manager.cc:225: bitmap.width() * bitmap.bytesPerPixel(), 100, dest); On 2014/09/26 19:27:36, ...
6 years, 2 months ago (2014-09-26 19:50:03 UTC) #4
Lei Zhang
The diff from the last commit attempt LGTM.
6 years, 2 months ago (2014-09-26 20:52:12 UTC) #5
huangs
lgtm
6 years, 2 months ago (2014-09-26 21:23:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607183002/60001
6 years, 2 months ago (2014-09-29 13:43:03 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/8026)
6 years, 2 months ago (2014-09-29 14:30:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607183002/60001
6 years, 2 months ago (2014-09-29 15:03:27 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 6f16aa8615ef3ea9c3db528543be697c7390b693
6 years, 2 months ago (2014-09-29 15:25:20 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 15:26:24 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/c3c8b0ee0631eca2eb313f2be2f68edf772e6ef9
Cr-Commit-Position: refs/heads/master@{#297177}

Powered by Google App Engine
This is Rietveld 408576698