Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: tools/gn/command_format_unittest.cc

Issue 607173002: gn format: fix comments at end of blocks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clang warning Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/command_format_unittest.cc
diff --git a/tools/gn/command_format_unittest.cc b/tools/gn/command_format_unittest.cc
index f7fa0013808c53c02fac5cf45afb59d0964536fb..5e6cfd20e0c6cdd51fb72344b4e6950f3c691df4 100644
--- a/tools/gn/command_format_unittest.cc
+++ b/tools/gn/command_format_unittest.cc
@@ -24,7 +24,7 @@ bool FormatFileToString(const std::string& input_filename,
FILE_PATH_LITERAL(#n) \
FILE_PATH_LITERAL(".golden")), \
&expected)); \
- EXPECT_EQ(out, expected); \
+ EXPECT_EQ(expected, out); \
}
// These are expanded out this way rather than a runtime loop so that
@@ -43,3 +43,6 @@ FORMAT_TEST(011)
FORMAT_TEST(012)
FORMAT_TEST(013)
FORMAT_TEST(014)
+FORMAT_TEST(015)
+// TODO(scottmg): Requires precedence/parentheses FORMAT_TEST(016)
+FORMAT_TEST(017)

Powered by Google App Engine
This is Rietveld 408576698