Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 607163002: Copy latest data reduction proxy urls to params. (Closed)

Created:
6 years, 2 months ago by Not at Google. Contact bengr
Modified:
6 years, 2 months ago
Reviewers:
bengr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Copy latest data reduction proxy urls to params. BUG=418125 Committed: https://crrev.com/2a102d23f146bb4f565660cc6b36819d04c209b6 Cr-Commit-Position: refs/heads/master@{#297002}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added comment for kDefaultSslOrigin. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M components/data_reduction_proxy/browser/data_reduction_proxy_params.cc View 1 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Not at Google. Contact bengr
bengr: components/data_reduction_proxy/browser/data_reduction_proxy_params.cc
6 years, 2 months ago (2014-09-26 18:19:11 UTC) #2
bengr
lgtm, please verify dev and alt configurations before submitting.
6 years, 2 months ago (2014-09-26 18:21:00 UTC) #3
bengr
https://codereview.chromium.org/607163002/diff/1/components/data_reduction_proxy/browser/data_reduction_proxy_params.cc File components/data_reduction_proxy/browser/data_reduction_proxy_params.cc (right): https://codereview.chromium.org/607163002/diff/1/components/data_reduction_proxy/browser/data_reduction_proxy_params.cc#newcode33 components/data_reduction_proxy/browser/data_reduction_proxy_params.cc:33: const char kDefaultSslOrigin[] = "http://ssl.googlezip.net:443/"; Please add a comment ...
6 years, 2 months ago (2014-09-26 18:26:26 UTC) #4
Not at Google. Contact bengr
https://codereview.chromium.org/607163002/diff/1/components/data_reduction_proxy/browser/data_reduction_proxy_params.cc File components/data_reduction_proxy/browser/data_reduction_proxy_params.cc (right): https://codereview.chromium.org/607163002/diff/1/components/data_reduction_proxy/browser/data_reduction_proxy_params.cc#newcode33 components/data_reduction_proxy/browser/data_reduction_proxy_params.cc:33: const char kDefaultSslOrigin[] = "http://ssl.googlezip.net:443/"; On 2014/09/26 18:26:26, bengr1 ...
6 years, 2 months ago (2014-09-26 18:28:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607163002/20001
6 years, 2 months ago (2014-09-26 18:31:07 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as fc98884c33df6ff1c64f673d3cd41ab184f1ead2
6 years, 2 months ago (2014-09-26 19:28:34 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 19:29:14 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a102d23f146bb4f565660cc6b36819d04c209b6
Cr-Commit-Position: refs/heads/master@{#297002}

Powered by Google App Engine
This is Rietveld 408576698