Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 607073002: Gyp cleanup after CL495353003 (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Gyp cleanup after https://codereview.chromium.org/495353003 BUG=408338 Committed: https://crrev.com/d9983ebf4b5464ddad65acd4f7692af72ce2a78f Cr-Commit-Position: refs/heads/master@{#296999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M media/blink/media_blink.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@scherkus: PTAL at this tiny cleanup.
6 years, 2 months ago (2014-09-26 12:57:53 UTC) #2
scherkus (not reviewing)
lgtm
6 years, 2 months ago (2014-09-26 18:26:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607073002/1
6 years, 2 months ago (2014-09-26 18:27:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as f41fc7d093f477d8f4501fa878e04a2f9380eac6
6 years, 2 months ago (2014-09-26 19:20:37 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 19:21:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9983ebf4b5464ddad65acd4f7692af72ce2a78f
Cr-Commit-Position: refs/heads/master@{#296999}

Powered by Google App Engine
This is Rietveld 408576698