Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 607043002: Script streaming: fix split UTF-8 character handling. (Closed)

Created:
6 years, 2 months ago by marja
Modified:
6 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Script streaming: fix split UTF-8 character handling. Invalid UTF-8 data can contain too many characters which look like they're part of a multi-byte character, and that was overflowing a buffer. BUG=chromium:417891 LOG=n . R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24251

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M src/scanner-character-streams.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
marja
yangguo, ptal
6 years, 2 months ago (2014-09-26 10:11:00 UTC) #2
Yang
On 2014/09/26 10:11:00, marja wrote: > yangguo, ptal lgtm.
6 years, 2 months ago (2014-09-26 11:11:49 UTC) #3
marja
6 years, 2 months ago (2014-09-26 11:17:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24251 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698