Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 607033002: Take output type into account in JSTypedLowering reduction. (Closed)

Created:
6 years, 2 months ago by neis
Modified:
6 years, 2 months ago
Reviewers:
rossberg
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Take output type into account in JSTypedLowering reduction. R=rossberg@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24287

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
neis
6 years, 2 months ago (2014-09-26 09:09:57 UTC) #1
rossberg
lgtm
6 years, 2 months ago (2014-09-26 09:42:46 UTC) #2
neis1
I added a check to avoid replacing a node that's already a leaf.
6 years, 2 months ago (2014-09-27 15:18:36 UTC) #3
neis
6 years, 2 months ago (2014-09-29 13:15:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24287 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698