Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 60703003: Docserver: Fix a bug where API properties were not showing their type. (Closed)

Created:
7 years, 1 month ago by dhnishi (use Chromium)
Modified:
7 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix a bug where API properties were not showing their type. Before: http://i.imgur.com/U1IMJZc.png After: http://i.imgur.com/2uWTmzi.png NOTRY=true BUG=246200 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/extensions/docs/templates/private/api_property.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dhnishi (use Chromium)
PTAL when you get a moment.
7 years, 1 month ago (2013-11-05 19:40:20 UTC) #1
not at google - send to devlin
lgtm
7 years, 1 month ago (2013-11-05 19:41:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/DHNishi@gmail.com/60703003/1
7 years, 1 month ago (2013-11-05 20:22:41 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 20:34:11 UTC) #4
Message was sent while issue was closed.
Change committed as 233074

Powered by Google App Engine
This is Rietveld 408576698