Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: apps/BUILD.gn

Issue 606953002: Move components/native_app_window to extensions/components/native_app_window (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: patchfail/rebase Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | apps/apps.gypi » ('j') | apps/apps.gypi » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 7
8 static_library("apps") { 8 static_library("apps") {
9 sources = [ 9 sources = [
10 "app_lifetime_monitor.cc", 10 "app_lifetime_monitor.cc",
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 ] 61 ]
62 sources = [] 62 sources = []
63 } 63 }
64 64
65 if (toolkit_views) { 65 if (toolkit_views) {
66 sources += [ 66 sources += [
67 "ui/views/app_window_frame_view.cc", 67 "ui/views/app_window_frame_view.cc",
68 "ui/views/app_window_frame_view.h", 68 "ui/views/app_window_frame_view.h",
69 ] 69 ]
70 deps += [ 70 deps += [
71 "//extensions/components/native_app_window",
tapted 2014/09/29 06:03:31 this dep was previously missing from the gn file (
oshima 2014/09/29 18:47:14 This should be "extensions/browser"
tapted 2014/09/29 23:22:41 I think this one is handled by the dependencies in
tapted 2014/09/29 23:25:53 oh oops. I see. There's not actually a need for ap
tapted 2014/09/30 04:02:46 Done.
71 "//ui/strings", 72 "//ui/strings",
72 "//ui/views", 73 "//ui/views",
73 ] 74 ]
74 } 75 }
75 76
76 if (is_win) { 77 if (is_win) {
77 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 78 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
78 cflags = [ "/wd4267" ] 79 cflags = [ "/wd4267" ]
79 } 80 }
80 } 81 }
OLDNEW
« no previous file with comments | « no previous file | apps/apps.gypi » ('j') | apps/apps.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698