PDF: Change the rotate shortcut keys to ctrl+[] on all platforms.

pdf/instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/instance.h"
 
 #include <algorithm>  // for min()
 #define _USE_MATH_DEFINES  // for M_PI
 #include <cmath>      // for log() and pow()
 #include <math.h>
@@ skipping 569 matching lines @@
     if (set_timer) {
       last_mouse_event_ = pp::MouseInputEvent(event);
 
       pp::CompletionCallback callback =
           timer_factory_.NewCallback(&Instance::OnTimerFired);
       pp::Module::Get()->core()->CallOnMainThread(kDragTimerMs, callback);
       timer_pending_ = true;
     }
   }
 
-  if (event.GetType() == PP_INPUTEVENT_TYPE_KEYDOWN &&
-      event.GetModifiers() & kDefaultKeyModifier) {
+  if (event.GetType() == PP_INPUTEVENT_TYPE_KEYDOWN) {
     pp::KeyboardInputEvent keyboard_event(event);
-    switch (keyboard_event.GetKeyCode()) {
-      case 'A':
-        engine_->SelectAll();
-        return true;
-      case ui::VKEY_OEM_4:
-        // Left bracket.
-        engine_->RotateCounterclockwise();
-        return true;
-      case ui::VKEY_OEM_6:
-        // Right bracket.
-        engine_->RotateClockwise();
-        return true;
+    if (event.GetModifiers() & kDefaultKeyModifier) {
+      switch (keyboard_event.GetKeyCode()) {
+        case 'A':
+          engine_->SelectAll();
+          return true;
+      }
+    }
+    else if (event.GetModifiers() & PP_INPUTEVENT_MODIFIER_CONTROLKEY) {

[raymes, 2014/09/26 02:49:26]

nit: shift onto the previous line

[Lei Zhang, 2014/09/26 04:31:41]

Done.

+      switch (keyboard_event.GetKeyCode()) {
+        case ui::VKEY_OEM_4:
+          // Left bracket.
+          engine_->RotateCounterclockwise();
+          return true;
+        case ui::VKEY_OEM_6:
+          // Right bracket.
+          engine_->RotateClockwise();
+          return true;
+      }
     }
   }
 
   // Return true for unhandled clicks so the plugin takes focus.
   return (event.GetType() == PP_INPUTEVENT_TYPE_MOUSEDOWN);
 }
 
 void Instance::DidChangeView(const pp::View& view) {
   pp::Rect view_rect(view.GetRect());
   float device_scale = 1.0f;
@@ skipping 2136 matching lines @@
   return instance_->HasScriptableMethod(name, exception);
 }
 
 pp::Var PDFScriptableObject::Call(const pp::Var& method,
                                   const std::vector<pp::Var>& args,
                                   pp::Var* exception) {
   return instance_->CallScriptableMethod(method, args, exception);
 }
 
 }  // namespace chrome_pdf