Protect against setting meta info on unmodifiable nodes.

chrome/test/data/extensions/api_test/bookmark_manager/standard/test.js

Index: chrome/test/data/extensions/api_test/bookmark_manager/standard/test.js
diff --git a/chrome/test/data/extensions/api_test/bookmark_manager/standard/test.js b/chrome/test/data/extensions/api_test/bookmark_manager/standard/test.js
index e09929ebc35af5637cd32dd8d833e86fb9368b0a..f424eafe979e6a1edad2f5d7d33608d606af2f2a 100644
--- a/chrome/test/data/extensions/api_test/bookmark_manager/standard/test.js
+++ b/chrome/test/data/extensions/api_test/bookmark_manager/standard/test.js
@@ -341,6 +341,16 @@ var tests = [
     }));
   },
 
+  function setMetaInfoUnmodifiable() {
+    bookmarks.getTree(pass(function(nodes) {
+      var unmodifiableFolder = nodes[0].children[0];
+      bookmarkManager.setMetaInfo(unmodifiableFolder.id, 'meta', 'foo', fail(

[Jeffrey Yasskin, 2014/09/26 01:19:19]

I saw two checks in the real code, for !CanBeModified() and for
is_permanent_node(). Can you write tests for both of them?

[Rune Fevang, 2014/09/26 20:44:06]

Done.

+          "Can't modify the root bookmark folders."));
+      bookmarkManager.updateMetaInfo(unmodifiableFolder.id, {a: 'a', b: 'b'},
+          fail("Can't modify the root bookmark folders."));
+    }));
+  },
+
   function updateMetaInfo() {
     bookmarkManager.getMetaInfo(nodeB.id, pass(function(result){
       assertEq({}, result);