Protect against setting meta info on unmodifiable nodes.

chrome/test/data/extensions/api_test/bookmark_manager/standard/test.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Bookmark Manager API test for Chrome.
 // browser_tests.exe --gtest_filter=ExtensionApiTest.BookmarkManager
 
 const pass = chrome.test.callbackPass;
 const fail = chrome.test.callbackFail;
 const assertEq = chrome.test.assertEq;
@@ skipping 323 matching lines @@
     bookmarkManager.setMetaInfo(nodeA.id, 'meta2', 'foo');
     bookmarkManager.getMetaInfo(nodeA.id, 'meta', pass(function(result) {
       assertEq('bla', result);
     }));
 
     bookmarkManager.getMetaInfo(nodeA.id, pass(function(result) {
       assertEq({meta: 'bla', meta2: 'foo'}, result);
     }));
   },
 
+  function setMetaInfoUnmodifiable() {
+    bookmarks.getTree(pass(function(nodes) {
+      var unmodifiableFolder = nodes[0].children[0];
+      bookmarkManager.setMetaInfo(unmodifiableFolder.id, 'meta', 'foo', fail(

[Jeffrey Yasskin, 2014/09/26 01:19:19]

I saw two checks in the real code, for !CanBeModified() and for
is_permanent_node(). Can you write tests for both of them?

[Rune Fevang, 2014/09/26 20:44:06]

Done.

+          "Can't modify the root bookmark folders."));
+      bookmarkManager.updateMetaInfo(unmodifiableFolder.id, {a: 'a', b: 'b'},
+          fail("Can't modify the root bookmark folders."));
+    }));
+  },
+
   function updateMetaInfo() {
     bookmarkManager.getMetaInfo(nodeB.id, pass(function(result){
       assertEq({}, result);
     }));
 
     chrome.test.listenOnce(bookmarkManager.onMetaInfoChanged, pass(
         function(id, changes) {
       assertEq(nodeB.id, id);
       assertEq({a: 'a', b: 'b', c: 'c'}, changes);
     }));
@@ skipping 23 matching lines @@
     }));
     bookmarkManager.createWithMetaInfo(node, metaInfo, pass(
         function(createdNode) {
       assertEq(node.title, createdNode.title);
       assertEq(node.url, createdNode.url);
     }));
   }
 ];
 
 chrome.test.runTests(tests);