Protect against setting meta info on unmodifiable nodes.

chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.h"
 
 #include <vector>
 
 #include "base/lazy_instance.h"
 #include "base/memory/linked_ptr.h"
@@ skipping 703 matching lines @@
 }
 
 bool BookmarkManagerPrivateSetMetaInfoFunction::RunOnReady() {
   scoped_ptr<SetMetaInfo::Params> params(SetMetaInfo::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
 
   const BookmarkNode* node = GetBookmarkNodeFromId(params->id);
   if (!node)
     return false;
 
+  if (!CanBeModified(node))
+    return false;
+
   BookmarkModel* model = BookmarkModelFactory::GetForProfile(GetProfile());
+  if (model->is_permanent_node(node)) {
+    error_ = bookmark_keys::kModifySpecialError;
+    return false;
+  }
+
   model->SetNodeMetaInfo(node, params->key, params->value);
   return true;
 }
 
 bool BookmarkManagerPrivateUpdateMetaInfoFunction::RunOnReady() {
   scoped_ptr<UpdateMetaInfo::Params> params(
       UpdateMetaInfo::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
 
   const BookmarkNode* node = GetBookmarkNodeFromId(params->id);
   if (!node)
     return false;
 
+  if (!CanBeModified(node))
+    return false;
+
   BookmarkModel* model = BookmarkModelFactory::GetForProfile(GetProfile());
+  if (model->is_permanent_node(node)) {
+    error_ = bookmark_keys::kModifySpecialError;
+    return false;
+  }
+
   BookmarkNode::MetaInfoMap new_meta_info(
       params->meta_info_changes.additional_properties);
   if (node->GetMetaInfoMap()) {
     new_meta_info.insert(node->GetMetaInfoMap()->begin(),
                          node->GetMetaInfoMap()->end());
   }
   model->SetNodeMetaInfoMap(node, new_meta_info);
 
   return true;
 }
@@ skipping 52 matching lines @@
 
   RedoInfo::Results::Result result;
   result.enabled = undo_manager->redo_count() > 0;
   result.label = base::UTF16ToUTF8(undo_manager->GetRedoLabel());
 
   results_ = RedoInfo::Results::Create(result);
   return true;
 }
 
 }  // namespace extensions