Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: ui/display/chromeos/display_configurator_unittest.cc

Issue 606913002: chromeos: Choose monitor native mode as best match mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: formatting Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/display/chromeos/display_configurator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/display/chromeos/display_configurator_unittest.cc
diff --git a/ui/display/chromeos/display_configurator_unittest.cc b/ui/display/chromeos/display_configurator_unittest.cc
index aecaddd020cf6a50581d78c33e3e8462ce9f303d..a43ac9b835961e4e70ba09741b2e3ef64c7fa79e 100644
--- a/ui/display/chromeos/display_configurator_unittest.cc
+++ b/ui/display/chromeos/display_configurator_unittest.cc
@@ -439,6 +439,9 @@ TEST_F(DisplayConfiguratorTest, FindDisplayModeMatchingSize) {
// Fields are width, height, interlaced, refresh rate.
modes.push_back(new DisplayMode(gfx::Size(1920, 1200), false, 60.0));
+ DisplayMode* native_mode =
+ new DisplayMode(gfx::Size(1920, 1200), false, 50.0);
+ modes.push_back(native_mode);
// Different rates.
modes.push_back(new DisplayMode(gfx::Size(1920, 1080), false, 30.0));
modes.push_back(new DisplayMode(gfx::Size(1920, 1080), false, 50.0));
@@ -462,40 +465,42 @@ TEST_F(DisplayConfiguratorTest, FindDisplayModeMatchingSize) {
TestDisplaySnapshot output;
output.set_modes(modes.get());
+ output.set_native_mode(native_mode);
- EXPECT_EQ(modes[0],
+ // Should pick native over highest refresh rate.
+ EXPECT_EQ(modes[1],
DisplayConfigurator::FindDisplayModeMatchingSize(
output, gfx::Size(1920, 1200)));
// Should pick highest refresh rate.
- EXPECT_EQ(modes[2],
+ EXPECT_EQ(modes[3],
DisplayConfigurator::FindDisplayModeMatchingSize(
output, gfx::Size(1920, 1080)));
// Should pick non-interlaced mode.
- EXPECT_EQ(modes[6],
+ EXPECT_EQ(modes[7],
DisplayConfigurator::FindDisplayModeMatchingSize(
output, gfx::Size(1280, 720)));
// Interlaced only. Should pick one with the highest refresh rate in
// interlaced mode.
- EXPECT_EQ(modes[9],
+ EXPECT_EQ(modes[10],
DisplayConfigurator::FindDisplayModeMatchingSize(
output, gfx::Size(1024, 768)));
// Mixed: Should pick one with the highest refresh rate in
// interlaced mode.
- EXPECT_EQ(modes[12],
+ EXPECT_EQ(modes[13],
DisplayConfigurator::FindDisplayModeMatchingSize(
output, gfx::Size(1024, 600)));
// Just one interlaced mode.
- EXPECT_EQ(modes[13],
+ EXPECT_EQ(modes[14],
DisplayConfigurator::FindDisplayModeMatchingSize(
output, gfx::Size(640, 480)));
// Refresh rate not available.
- EXPECT_EQ(modes[14],
+ EXPECT_EQ(modes[15],
DisplayConfigurator::FindDisplayModeMatchingSize(
output, gfx::Size(320, 200)));
« no previous file with comments | « ui/display/chromeos/display_configurator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698