Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: runtime/vm/assembler_arm.cc

Issue 606893002: Avoids vmovsr on ARM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_arm.cc
===================================================================
--- runtime/vm/assembler_arm.cc (revision 40686)
+++ runtime/vm/assembler_arm.cc (working copy)
@@ -691,6 +691,24 @@
}
+void Assembler::vmovdr(DRegister dn, int i, Register rt, Condition cond) {
+ ASSERT(TargetCPUFeatures::vfp_supported());
+ ASSERT((i == 0) || (i == 1));
+ ASSERT(rt != kNoRegister);
+ ASSERT(rt != SP);
+ ASSERT(rt != PC);
+ ASSERT(dn != kNoDRegister);
+ ASSERT(cond != kNoCondition);
+ int32_t encoding = (static_cast<int32_t>(cond) << kConditionShift) |
+ B27 | B26 | B25 |
+ (i*B21) |
+ (static_cast<int32_t>(rt)*B12) | B11 | B9 | B8 |
+ ((static_cast<int32_t>(dn) >> 4)*B7) |
+ ((static_cast<int32_t>(dn) & 0xf)*B16) | B4;
+ Emit(encoding);
+}
+
+
void Assembler::vmovdrr(DRegister dm, Register rt, Register rt2,
Condition cond) {
ASSERT(TargetCPUFeatures::vfp_supported());
@@ -2454,8 +2472,10 @@
void Assembler::LoadSImmediate(SRegister sd, float value, Condition cond) {
if (!vmovs(sd, value, cond)) {
+ const DRegister dd = static_cast<DRegister>(sd >> 1);
+ const int index = sd & 1;
LoadImmediate(IP, bit_cast<int32_t, float>(value), cond);
- vmovsr(sd, IP, cond);
+ vmovdr(dd, index, IP, cond);
}
}

Powered by Google App Engine
This is Rietveld 408576698