mojo/services/native_viewport/platform_viewport.h - Issue 606883002: Add a headless configuration to Mojo's native viewport service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/native_viewport/platform_viewport.h

Issue 606883002: Add a headless configuration to Mojo's native viewport service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/services/native_viewport/native_viewport_impl.h ('K') | « mojo/services/native_viewport/native_viewport_impl.cc ('k') | mojo/services/native_viewport/platform_viewport_headless.h » ('j') | mojo/services/native_viewport/platform_viewport_headless.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/native_viewport/platform_viewport.h

diff --git a/mojo/services/native_viewport/platform_viewport.h b/mojo/services/native_viewport/platform_viewport.h

index f42eb7d273454400a9e8d6c0f74f0be0d58740f6..a3ba3dcc10dacc453b0f19c78aa95b5d7e38a35c 100644

--- a/mojo/services/native_viewport/platform_viewport.h

+++ b/mojo/services/native_viewport/platform_viewport.h

@@ -26,7 +26,7 @@ class PlatformViewport {

public:

virtual ~Delegate() {}

- virtual void OnBoundsChanged(const gfx::Rect& size) = 0;

+ virtual void OnBoundsChanged(const gfx::Rect& rect) = 0;

jamesr 2014/09/25 22:18:14 hmm? i don't understand this change

abarth-chromium 2014/09/25 23:31:36 I renamed the formal parameter. It is a rect, not

virtual void OnAcceleratedWidgetAvailable(

gfx::AcceleratedWidget widget) = 0;

virtual bool OnEvent(ui::Event* ui_event) = 0;