Add a headless configuration to Mojo's native viewport service

Add a headless configuration to Mojo's native viewport service

Rather than talking to X11, in headless mode, the native viewport service just
drops requests on the floor. This configuration is useful for writing
integration tests for the Mojo system that don't need to interact with X11.

R=jamesr@chromium.org

Committed: https://crrev.com/cff892f9c3062ddd2ac7e3c2385a5fb63be0b886
Cr-Commit-Position: refs/heads/master@{#296846}

[jamesr, 2014-09-25 22:18:15]

As we discussed in person, I think it'd be even better if the ecosystem allowed
for injecting a different implementation of the mojo::NativeViewport interface
rather than tweaking the implementation in mojo/services/, but we don't support
that yet and this seems like a fine stopgap measure.

lgtm

https://codereview.chromium.org/606883002/diff/1/mojo/services/native_viewpor...
File mojo/services/native_viewport/main.cc (right):

https://codereview.chromium.org/606883002/diff/1/mojo/services/native_viewpor...
mojo/services/native_viewport/main.cc:46: const mojo::Callback<void()>&
callback) OVERRIDE {
this code is in namespace mojo, no need to specify mojo:: again here

https://codereview.chromium.org/606883002/diff/1/mojo/services/native_viewpor...
File mojo/services/native_viewport/native_viewport_impl.h (right):

https://codereview.chromium.org/606883002/diff/1/mojo/services/native_viewpor...
mojo/services/native_viewport/native_viewport_impl.h:27: explicit
NativeViewportImpl(ApplicationImpl* app,
you can drop 'explicit' now that it's 2 args (and we don't support initializer
list syntax...yet)

https://codereview.chromium.org/606883002/diff/1/mojo/services/native_viewpor...
File mojo/services/native_viewport/platform_viewport.h (right):

https://codereview.chromium.org/606883002/diff/1/mojo/services/native_viewpor...
mojo/services/native_viewport/platform_viewport.h:29: virtual void
OnBoundsChanged(const gfx::Rect& rect) = 0;
hmm? i don't understand this change

https://codereview.chromium.org/606883002/diff/1/mojo/services/native_viewpor...
File mojo/services/native_viewport/platform_viewport_headless.h (right):

https://codereview.chromium.org/606883002/diff/1/mojo/services/native_viewpor...
mojo/services/native_viewport/platform_viewport_headless.h:15: static
scoped_ptr<PlatformViewport> Create(Delegate* delegate);
why are both the constructor and this factory function public? with a public
factory i would expect the constructor to be private

[abarth-chromium, 2014-09-25 23:31:36]

Addressed all comments.

https://codereview.chromium.org/606883002/diff/1/mojo/services/native_viewpor...
File mojo/services/native_viewport/platform_viewport.h (right):

https://codereview.chromium.org/606883002/diff/1/mojo/services/native_viewpor...
mojo/services/native_viewport/platform_viewport.h:29: virtual void
OnBoundsChanged(const gfx::Rect& rect) = 0;
On 2014/09/25 at 22:18:14, jamesr wrote:
> hmm? i don't understand this change

I renamed the formal parameter.  It is a rect, not a size.

https://codereview.chromium.org/606883002/diff/1/mojo/services/native_viewpor...
File mojo/services/native_viewport/platform_viewport_headless.h (right):

https://codereview.chromium.org/606883002/diff/1/mojo/services/native_viewpor...
mojo/services/native_viewport/platform_viewport_headless.h:15: static
scoped_ptr<PlatformViewport> Create(Delegate* delegate);
On 2014/09/25 at 22:18:14, jamesr wrote:
> why are both the constructor and this factory function public? with a public
factory i would expect the constructor to be private

Made the constructor private.

[abarth-chromium, 2014-09-25 23:35:15]

The CQ bit was checked by abarth@chromium.org

[commit-bot: I haz the power, 2014-09-25 23:36:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/606883002/20001

[commit-bot: I haz the power, 2014-09-26 01:12:23]

Committed patchset #2 (id:20001) as c588205f566b4cd9827db34e2e7e6886d7e09c2f

[commit-bot: I haz the power, 2014-09-26 01:12:50]

Patchset 2 (id:??) landed as
https://crrev.com/cff892f9c3062ddd2ac7e3c2385a5fb63be0b886
Cr-Commit-Position: refs/heads/master@{#296846}