Issue 60683002: Revert 233048 "Support policies referencing external data for de..."

Issue 60683002: Revert 233048 "Support policies referencing external data for de..." (Closed)

Created:
7 years, 1 month ago by bartfab (slow)

Modified:
7 years, 1 month ago

Reviewers:
bartfab (slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 233048 "Support policies referencing external data for de..." The CL broke compilation on Chrome OS. > Support policies referencing external data for device-local accounts > > This CL adds a DeviceLocalAccountExternalDataService that provides each > device-local account with a DeviceLocalAccountExternalDataManager which > fetches, caches and retrieves external policy data. > > BUG=256635 > TEST=New browser test > R=derat@chromium.org, joaodasilva@chromium.org > > Review URL: https://codereview.chromium.org/25242002 TBR=bartfab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233051

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+120 lines, -645 lines)			Patch
D	trunk/src/chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.h	View	1 chunk	+0 lines, -47 lines	0 comments	Download
D	trunk/src/chrome/browser/chromeos/policy/cloud_external_data_manager_base_test_util.cc	View	1 chunk	+0 lines, -56 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/policy/device_local_account_browsertest.cc	View	9 chunks	+1 line, -159 lines	0 comments	Download
D	trunk/src/chrome/browser/chromeos/policy/device_local_account_external_data_manager.h	View	1 chunk	+0 lines, -67 lines	0 comments	Download
D	trunk/src/chrome/browser/chromeos/policy/device_local_account_external_data_manager.cc	View	1 chunk	+0 lines, -41 lines	0 comments	Download
D	trunk/src/chrome/browser/chromeos/policy/device_local_account_external_data_service.h	View	1 chunk	+0 lines, -63 lines	0 comments	Download
D	trunk/src/chrome/browser/chromeos/policy/device_local_account_external_data_service.cc	View	1 chunk	+0 lines, -88 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/policy/device_local_account_policy_provider.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/policy/device_local_account_policy_provider.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/policy/device_local_account_policy_service.h	View	8 chunks	+9 lines, -28 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/policy/device_local_account_policy_service.cc	View	12 chunks	+22 lines, -38 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc	View	5 chunks	+9 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/policy/user_cloud_external_data_manager_browsertest.cc	View	4 chunks	+70 lines, -16 lines	0 comments	Download
M	trunk/src/chrome/browser/policy/browser_policy_connector.cc	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/browser/policy/cloud/cloud_external_data_manager.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/chrome_browser_chromeos.gypi	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/chromeos/chromeos_paths.h	View	1 chunk	+4 lines, -7 lines	0 comments	Download
M	trunk/src/chromeos/chromeos_paths.cc	View	2 chunks	+3 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r233051.

Expand Messages | Collapse Messages