Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 606783002: Avoid null cgFont crash in harfBuzzCoreTextGetTable (Closed)

Created:
6 years, 2 months ago by Dominik Röttsches
Modified:
6 years, 2 months ago
Reviewers:
behdad_google, eae
CC:
blink-reviews, jamesr, pdr+graphicswatchlist_chromium.org, jbroman, mkwst+moarreviews_chromium.org, danakj, Rik, Stephen Chennney, krit, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Avoid null cgFont crash in harfBuzzCoreTextGetTable The right fix is to remove all cgFont, NSFont and ctFont pointers in FontPlatformData. BUG=417391 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182749

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Source/platform/fonts/harfbuzz/HarfBuzzFaceCoreText.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
eae
LGTM
6 years, 2 months ago (2014-09-25 16:09:29 UTC) #2
behdad_google
lgtm
6 years, 2 months ago (2014-09-25 16:09:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606783002/1
6 years, 2 months ago (2014-09-26 07:42:48 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 09:42:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182749

Powered by Google App Engine
This is Rietveld 408576698