Issue 606753002: Add the missing input method indicator texts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 606753002: Add the missing input method indicator texts. (Closed)

Created:
6 years, 2 months ago by Shu Chen

Modified:
6 years, 2 months ago

Reviewers:
Seigo Nonaka

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add the missing input method indicator texts. BUG=417738 TEST=Verified on linux_chromeos. Committed: https://crrev.com/c73f59d045cbc0996362de759758684a16279bb7 Cr-Commit-Position: refs/heads/master@{#296724}

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/browser/chromeos/input_method/input_method_util.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606753002/1

6 years, 2 months ago (2014-09-25 15:48:55 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as aa59286eef2a622bbbcef41cb2f7be4b5928d446

6 years, 2 months ago (2014-09-25 16:55:42 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-09-25 16:56:18 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c73f59d045cbc0996362de759758684a16279bb7
Cr-Commit-Position: refs/heads/master@{#296724}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages