Delete AXObjectCache when disabling accessibility setting.

Delete AXObjectCache when disabling accessibility setting.

BUG=251382
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183564

[dmazzoni, 2014-09-25 16:45:43]

dmazzoni@chromium.org changed reviewers:
+ abarth@chromium.org

[dmazzoni, 2014-09-30 18:21:51]

Ping

[dmazzoni, 2014-10-01 21:27:59]

dmazzoni@chromium.org changed reviewers:
+ esprehn@chromium.org
- abarth@chromium.org

[dmazzoni, 2014-10-01 21:28:00]

+esprehn

[esprehn, 2014-10-01 23:30:39]

What about all the child frames of the main frame?

[dmazzoni, 2014-10-01 23:43:49]

On 2014/10/01 23:30:39, esprehn wrote:
> What about all the child frames of the main frame?

AXObjectCache is only attached to the top document (see
Document::axObjectCacheOwner), and RenderFrame only toggles the accessibility
setting of the main frame.

[dmazzoni, 2014-10-06 16:35:49]

Ping

[eseidel, 2014-10-10 16:38:03]

eseidel@chromium.org changed reviewers:
+ eseidel@chromium.org

[eseidel, 2014-10-10 16:38:03]

Why do you want to make this non-autogenerated?  Why not just make this part of
the delegate?

[eseidel, 2014-10-10 16:43:19]

You don't need the changes to Settings.h, you can leave it autogenerated and
still get what you want.

otherwise rslgtm.  Jochen and pdr should be faster Blink reviewers than I am
right now.

https://codereview.chromium.org/606703003/diff/1/Source/core/frame/Settings.in
File Source/core/frame/Settings.in (left):

https://codereview.chromium.org/606703003/diff/1/Source/core/frame/Settings.i...
Source/core/frame/Settings.in:298: accessibilityEnabled initial=false
Just change this to "invalidate=Accisibility"

[dmazzoni, 2014-10-10 16:45:35]

https://codereview.chromium.org/606703003/diff/1/Source/core/frame/Settings.in
File Source/core/frame/Settings.in (left):

https://codereview.chromium.org/606703003/diff/1/Source/core/frame/Settings.i...
Source/core/frame/Settings.in:298: accessibilityEnabled initial=false
On 2014/10/10 16:43:19, eseidel wrote:
> Just change this to "invalidate=Accisibility"

Thanks - I missed that syntax

[dmazzoni, 2014-10-10 20:55:57]

Done, PTAL

[eseidel, 2014-10-10 22:10:27]

The CQ bit was checked by eseidel@chromium.org

[eseidel, 2014-10-10 22:10:28]

lgtm

[commit-bot: I haz the power, 2014-10-10 22:11:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/606703003/60001

[commit-bot: I haz the power, 2014-10-10 22:16:38]

Committed patchset #2 (id:60001) as 183564