Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 606703002: Comply (more) with check-webkit-style in and around HTMLMediaElement (Closed)

Created:
6 years, 2 months ago by philipj_slow
Modified:
6 years, 2 months ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-html_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium
Project:
blink
Visibility:
Public.

Description

Comply (more) with check-webkit-style in and around HTMLMediaElement R=fs@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182739

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -44 lines) Patch
M Source/core/html/HTMLMediaElement.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 9 chunks +27 lines, -26 lines 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/html/MediaFragmentURIParser.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/track/TextTrackList.cpp View 3 chunks +7 lines, -5 lines 0 comments Download
M Source/core/html/track/vtt/VTTElement.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
philipj_slow
6 years, 2 months ago (2014-09-25 14:43:10 UTC) #1
fs
lgtm
6 years, 2 months ago (2014-09-25 14:52:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606703002/1
6 years, 2 months ago (2014-09-25 14:52:18 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/28813)
6 years, 2 months ago (2014-09-25 17:31:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606703002/1
6 years, 2 months ago (2014-09-26 07:43:51 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 08:23:13 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 182739

Powered by Google App Engine
This is Rietveld 408576698