Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2189)

Unified Diff: Source/web/WebArrayBufferConverter.cpp

Issue 606653006: bindings: Adds DOMArrayBuffer, etc. as thin wrappers for ArrayBuffer, etc. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Synced. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/websockets/DOMWebSocketTest.cpp ('k') | Source/web/WebArrayBufferView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebArrayBufferConverter.cpp
diff --git a/Source/web/WebArrayBufferConverter.cpp b/Source/web/WebArrayBufferConverter.cpp
index 58d7a52af7b6676c9ab94decb9ce4e83ca8f4fb1..ce374d3d00f822828ea35743f89d231eb89fff5b 100644
--- a/Source/web/WebArrayBufferConverter.cpp
+++ b/Source/web/WebArrayBufferConverter.cpp
@@ -31,9 +31,7 @@
#include "config.h"
#include "public/web/WebArrayBufferConverter.h"
-#include "bindings/core/v8/custom/V8ArrayBufferCustom.h"
-#include "wtf/ArrayBuffer.h"
-#include "wtf/PassOwnPtr.h"
+#include "bindings/core/v8/V8ArrayBuffer.h"
namespace blink {
@@ -41,16 +39,15 @@ v8::Handle<v8::Value> WebArrayBufferConverter::toV8Value(WebArrayBuffer* buffer,
{
if (!buffer)
return v8::Handle<v8::Value>();
- return toV8(*buffer, creationContext, isolate);
+ return toV8(DOMArrayBuffer::create(*buffer), creationContext, isolate);
}
WebArrayBuffer* WebArrayBufferConverter::createFromV8Value(v8::Handle<v8::Value> value, v8::Isolate* isolate)
{
if (!V8ArrayBuffer::hasInstance(value, isolate))
return 0;
- ArrayBuffer* buffer = V8ArrayBuffer::toImpl(value->ToObject());
- return new WebArrayBuffer(buffer);
+ DOMArrayBuffer* buffer = V8ArrayBuffer::toImpl(value->ToObject());
+ return new WebArrayBuffer(buffer->buffer());
}
} // namespace blink
-
« no previous file with comments | « Source/modules/websockets/DOMWebSocketTest.cpp ('k') | Source/web/WebArrayBufferView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698